From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 09/16] net/axgbe: add DMA programming and dev
 start and stop apis
Date: Fri, 8 Dec 2017 13:07:30 -0800
Message-ID: <ab74c6be-4909-270c-6fa4-6b3ee4ff71c1@intel.com>
References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com>
 <1512047472-118050-9-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Shahaf Shuler <shahafs@mellanox.com>
To: Ravi Kumar <Ravi1.kumar@amd.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 2388B1B1C3
 for <dev@dpdk.org>; Fri,  8 Dec 2017 22:07:31 +0100 (CET)
In-Reply-To: <1512047472-118050-9-git-send-email-Ravi1.kumar@amd.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/30/2017 5:11 AM, Ravi Kumar wrote:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

<...>

> +/*
> + * Configure device link speed and setup link.
> + * It returns 0 on success.
> + */
> +static int
> +axgbe_dev_configure(struct rte_eth_dev *dev)
> +{
> +	struct axgbe_port *pdata =  dev->data->dev_private;
> +	/* Checksum offload to hardware */
> +	pdata->rx_csum_enable = dev->data->dev_conf.rxmode.hw_ip_checksum;

There is a new method to get offload requests from user, since this is new PMD I
believe it would be better to implement new method.

Shahaf cc'ed for more support if required.

<...>