From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix ixgbe private API calling Date: Wed, 11 Jan 2017 15:26:51 +0000 Message-ID: References: <1484102853-53205-1-git-send-email-wenzhuo.lu@intel.com> <8CEF83825BEC744B83065625E567D7C224D1CB14@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D1CCE7@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "Wu, Jingjing" , "stable@dpdk.org" To: "Iremonger, Bernard" , "Lu, Wenzhuo" , "dev@dpdk.org" Return-path: In-Reply-To: <8CEF83825BEC744B83065625E567D7C224D1CCE7@IRSMSX108.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/11/2017 3:20 PM, Iremonger, Bernard wrote: > Hi Wenzhuo, > > >>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling >>> >>> Some ixgbe private APIs are added to expose ixgbe specific functions. >>> When they're used by testpmd, there's no check for if the NICs are ixgbe. >>> Other NICs also have chance to call these APIs. >>> This patch add the check and the feedback print. >> >> I am not sure that testpmd is the right place to do this. >> The rte_pmd_ixgbe_* functions are public API's which can be called by other >> applications. >> The checks should be in the rte_pmd_ixgbe_* API's > > It is useful to handle the return code -ENOTSUP in testpmd. > Makes sense, and I think it is good idea to add them in your patch, since it introduces returning -ENOTSUP, would you mind sending a new version of your patch with this update? So we can drop this patch completely. Thanks, ferruh