public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Talluri Chaitanyababu <chaitanyababux.talluri@intel.com>
Cc: <dev@dpdk.org>, <aman.deep.singh@intel.com>, <shaiq.wani@intel.com>
Subject: Re: [PATCH v4] doc: improve e1000 driver documentation
Date: Wed, 11 Mar 2026 11:59:15 +0000	[thread overview]
Message-ID: <abFZEwRWbfuhwEAG@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260227162200.23972-1-chaitanyababux.talluri@intel.com>

On Fri, Feb 27, 2026 at 04:21:59PM +0000, Talluri Chaitanyababu wrote:
> Add an overview of the e1000 driver for Intel 1G devices.
> 
> Signed-off-by: Talluri Chaitanyababu <chaitanyababux.talluri@intel.com>
> ---
> v4:
> * Fixed RST structure, single top-level title.
> * Used ASCII "PCIe".
> * Adjusted commit message to match content.
> 
> v3: Resolved apply patch failure.
> 
> v2: Addressed review comments.
> ---
>  doc/guides/nics/e1000em.rst | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst
> index ed4f57e9c6..95ff68cb9b 100644
> --- a/doc/guides/nics/e1000em.rst
> +++ b/doc/guides/nics/e1000em.rst
> @@ -1,9 +1,22 @@
>  ..  SPDX-License-Identifier: BSD-3-Clause
> -    Copyright(c) 2010-2014 Intel Corporation.
> +    Copyright(c) 2010-2026 Intel Corporation.

Not an issue here, but FYI we don't generally update the copyright lines in
DPDK patches, we used to do so but in recent years community practice has
largely been to not do so..

>  
>  Driver for VM Emulated Devices
>  ==============================
>  
> +E1000 Poll Mode Driver
> +----------------------
> +
> +DPDK provides several poll mode drivers (PMDs) supporting Intel 1 Gigabit ethernet controller families.
> +These include:
> +
> +*   e1000 – Intel 8254x family devices, including QEMU ``e1000`` emulation.
> +*   e1000e – Intel PRO/1000 PCIe family.

We still have naming issues here where we have a mismatch between
documentation and code.

Specifically, if we run the pmdinfo script to see what is provided by the
librte_net_e1000.so file we get nothing listed that is just e1000 and no
mention of e1000e either:

$ ./usertools/dpdk-pmdinfo.py build/drivers/librte_net_e1000.so | grep name
    "name": "net_igc",
    "name": "net_e1000_igb_vf",
    "name": "net_e1000_igb",
    "name": "net_e1000_em",


> +
> +.. note::
> +
> +   The ``igb`` and ``igc`` PMDs are built from the same driver binary but are documented in separate sections for clarity.
> +
>  The DPDK EM poll mode driver supports the following emulated devices:

Presumably "DPDK EM" is e1000_em.

As part of cleanup of this doc, can you perhaps work to make the doc names
and the code names consistent and clear? We may want to look to rename some
of the drivers in the code here.

>  
>  *   qemu-kvm emulated Intel® 82540EM Gigabit Ethernet Controller (qemu e1000 device)
> -- 
> 2.43.0
> 

  reply	other threads:[~2026-03-11 12:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16 19:55 [PATCH] doc: improve e1000 driver documentation Talluri Chaitanyababu
2026-02-18 16:41 ` Bruce Richardson
2026-02-20 14:30 ` [PATCH v2] " Talluri Chaitanyababu
2026-02-20 21:15 ` [PATCH v3] " Talluri Chaitanyababu
2026-02-20 17:19   ` Stephen Hemminger
2026-02-25 15:36     ` Bruce Richardson
2026-02-27 15:26 ` Talluri Chaitanyababu
2026-02-27 16:21 ` [PATCH v4] " Talluri Chaitanyababu
2026-03-11 11:59   ` Bruce Richardson [this message]
2026-03-24 23:03 ` [PATCH v5] " Talluri Chaitanyababu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abFZEwRWbfuhwEAG@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=aman.deep.singh@intel.com \
    --cc=chaitanyababux.talluri@intel.com \
    --cc=dev@dpdk.org \
    --cc=shaiq.wani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox