From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH v2] net/i40e: validate raw flow items before dereferencing
Date: Wed, 11 Mar 2026 17:24:30 +0000 [thread overview]
Message-ID: <abGlTpezjYrq_NNL@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <abGIf-dWlkxYsrKi@bricha3-mobl1.ger.corp.intel.com>
On Wed, Mar 11, 2026 at 03:21:35PM +0000, Bruce Richardson wrote:
> On Mon, Mar 09, 2026 at 03:29:19PM +0000, Ciara Loftus wrote:
> > When a RTE_FLOW_ITEM_TYPE_RAW item is used with a non-zero length,
> > the spec and mask pattern pointers are dereferenced unconditionally
> > in a loop, causing a segfault if either is NULL. Additionally, no
> > check is made that the spec and mask have equal lengths before
> > iterating, which could result in out-of-bounds access.
> >
> > Add validation before the loop: reject the item if either pattern
> > pointer is NULL, or if the spec and mask lengths differ.
> >
> > Bugzilla ID: 1155
> > Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
>
> Missed carrying-forward Anatoly's ack from v1:
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2026-03-11 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 13:28 [PATCH] net/i40e: fix null dereference in raw flow item Ciara Loftus
2026-03-09 14:45 ` Burakov, Anatoly
2026-03-09 15:29 ` [PATCH v2] net/i40e: validate raw flow items before dereferencing Ciara Loftus
2026-03-11 15:21 ` Bruce Richardson
2026-03-11 17:24 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abGlTpezjYrq_NNL@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox