From: Bruce Richardson <bruce.richardson@intel.com>
To: Soumyadeep Hore <soumyadeep.hore@intel.com>
Cc: <manoj.kumar.subbarao@intel.com>, <aman.deep.singh@intel.com>,
<dev@dpdk.org>, <rajesh3.kumar@intel.com>
Subject: Re: [PATCH v1] net/i40e: remove dead ENOENT assignment
Date: Thu, 12 Mar 2026 10:00:42 +0000 [thread overview]
Message-ID: <abKOyn7Vl-TmmDMe@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260312221926.1476679-1-soumyadeep.hore@intel.com>
On Thu, Mar 12, 2026 at 06:19:26PM -0400, Soumyadeep Hore wrote:
> Ignore ENOENT from firmware without rewriting the return value.
>
> The previous code assigned I40E_SUCCESS to ret in the ENOENT case,
> but that value was never consumed before the next iteration or the
> function return path.
>
> Replace the positive ENOENT branch with a negative check so the
> control flow stays the same without the unused assignment.
>
> Coverity issue: 501831
>
> Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
> ---
> drivers/net/intel/i40e/i40e_ethdev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Duplicate of patch [1].
/Bruce
[1] https://patches.dpdk.org/project/dpdk/patch/20260311161955.1833722-1-john.mcnamara@intel.com/
prev parent reply other threads:[~2026-03-12 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 22:19 [PATCH v1] net/i40e: remove dead ENOENT assignment Soumyadeep Hore
2026-03-12 10:00 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abKOyn7Vl-TmmDMe@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=manoj.kumar.subbarao@intel.com \
--cc=rajesh3.kumar@intel.com \
--cc=soumyadeep.hore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox