public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, Praveen Shetty <praveen.shetty@intel.com>,
	Shaiq Wani <shaiq.wani@intel.com>
Subject: Re: [PATCH] net/idpf: fix comma operator warning
Date: Thu, 12 Mar 2026 16:57:46 +0000	[thread overview]
Message-ID: <abLwiikMS-apNzCP@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260312164344.957967-1-stephen@networkplumber.org>

On Thu, Mar 12, 2026 at 09:43:44AM -0700, Stephen Hemminger wrote:
> Fix comma operator misuse warnings with clang compiler in idpf that
> was missed in previous change. Shows up  when -Wcomma enabled.
> 
> Fixes: 57560a92167a ("net/idpf: add AVX2 Tx path for split queue config")
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Yep, this was missed because the previous commit [1] was on your tree but
not applied to main, so missing in mine. :-(

[1] https://patches.dpdk.org/project/dpdk/patch/20260219152302.2103018-1-bruce.richardson@intel.com/

>  drivers/net/intel/idpf/idpf_common_rxtx_avx2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> index 4e1062f22d..db7728afad 100644
> --- a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> +++ b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> @@ -842,7 +842,7 @@ idpf_splitq_vtx_avx2(struct idpf_flex_tx_sched_desc *txdp,
>  	/* align if needed */
>  	if (((uintptr_t)txdp & 0x1F) != 0 && nb_pkts != 0) {
>  		idpf_splitq_vtx1_avx2(txdp, *pkt, flags);
> -		txdp++, pkt++, nb_pkts--;
> +		txdp++; pkt++; nb_pkts--;
>  	}
>  
>  	for (; nb_pkts >= IDPF_VPMD_DESCS_PER_LOOP; txdp += IDPF_VPMD_DESCS_PER_LOOP,
> -- 
> 2.51.0
> 

  reply	other threads:[~2026-03-12 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 16:43 [PATCH] net/idpf: fix comma operator warning Stephen Hemminger
2026-03-12 16:57 ` Bruce Richardson [this message]
2026-03-25 22:53   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abLwiikMS-apNzCP@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=praveen.shetty@intel.com \
    --cc=shaiq.wani@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox