From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v1 4/5] pci: add req handler field to generic pci device Date: Wed, 26 Sep 2018 13:22:18 +0100 Message-ID: References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1534503091-31910-5-git-send-email-jia.guo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com To: Jeff Guo , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5A48E1B2AB for ; Wed, 26 Sep 2018 14:27:42 +0200 (CEST) In-Reply-To: <1534503091-31910-5-git-send-email-jia.guo@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17-Aug-18 11:51 AM, Jeff Guo wrote: > There are some extended interrupt types in vfio pci device except from the > existing interrupts, such as err and req notifier, it could be useful for > device error monitoring. And these corresponding interrupt handler is > different from the other interrupt handler that register in PMDs, so a new > interrupt handler should be added. This patch will add specific req handler > in generic pci device. > > Signed-off-by: Jeff Guo > --- > drivers/bus/pci/rte_bus_pci.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h > index 0d1955f..c45a820 100644 > --- a/drivers/bus/pci/rte_bus_pci.h > +++ b/drivers/bus/pci/rte_bus_pci.h > @@ -66,6 +66,7 @@ struct rte_pci_device { > uint16_t max_vfs; /**< sriov enable if not zero */ > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > char name[PCI_PRI_STR_SIZE+1]; /**< PCI location (ASCII) */ > + struct rte_intr_handle req_notifier_handler;/**< Req notifier handle */ > }; > > /** > Does this break ABI? -- Thanks, Anatoly