From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH v3 5/8] net/iavf: refactor sending virtchnl messages
Date: Fri, 3 Apr 2026 11:55:22 +0100 [thread overview]
Message-ID: <ac-cmsavhQdiBfWY@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <bade49dcf585835d368baaf2ee85d9a7ae1b19da.1772794442.git.anatoly.burakov@intel.com>
On Fri, Mar 06, 2026 at 10:58:21AM +0000, Anatoly Burakov wrote:
> Currently, there is a certain amount of duplication and unnecessary
> branching in the virtchnl message handling function which makes it
> difficult to read and reason about.
>
> Refactor the function to achieve the following:
>
> - clean and explicit distinction between synchronous and asynchronous ops
> - common looping and error handling logic
> - fewer and clearer special cases
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> drivers/net/intel/iavf/iavf_vchnl.c | 151 +++++++++++++---------------
> 1 file changed, 70 insertions(+), 81 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-04-03 10:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 12:09 [PATCH v1 1/1] net/iavf: remove global adminq response buffer Anatoly Burakov
2026-02-26 10:41 ` [PATCH v2 " Anatoly Burakov
2026-02-26 10:52 ` Burakov, Anatoly
2026-02-27 10:58 ` Bruce Richardson
2026-03-03 8:52 ` Bruce Richardson
2026-03-06 10:58 ` [PATCH v3 0/8] Reduce reliance on global response buffer in IAVF Anatoly Burakov
2026-03-06 10:58 ` [PATCH v3 1/8] net/iavf: avoid passing around pointers Anatoly Burakov
2026-04-03 10:37 ` Bruce Richardson
2026-03-06 10:58 ` [PATCH v3 2/8] net/iavf: add a variable for hena Anatoly Burakov
2026-04-03 10:39 ` Bruce Richardson
2026-03-06 10:58 ` [PATCH v3 3/8] net/iavf: add virtchnl interrupt enable flag Anatoly Burakov
2026-04-03 10:42 ` Bruce Richardson
2026-03-06 10:58 ` [PATCH v3 4/8] net/iavf: rework "async" virtchnl requests Anatoly Burakov
2026-04-03 10:52 ` Bruce Richardson
2026-03-06 10:58 ` [PATCH v3 5/8] net/iavf: refactor sending virtchnl messages Anatoly Burakov
2026-04-03 10:55 ` Bruce Richardson [this message]
2026-03-06 10:58 ` [PATCH v3 6/8] net/iavf: respect output buffer in virtchnl Anatoly Burakov
2026-04-03 11:08 ` Bruce Richardson
2026-03-06 10:58 ` [PATCH v3 7/8] net/iavf: do not use global virtchnl buffer Anatoly Burakov
2026-04-03 11:10 ` Bruce Richardson
2026-03-06 10:58 ` [PATCH v3 8/8] net/iavf: embed virtchnl response buffer Anatoly Burakov
2026-04-03 11:11 ` Bruce Richardson
2026-04-03 13:13 ` [PATCH v3 0/8] Reduce reliance on global response buffer in IAVF Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac-cmsavhQdiBfWY@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox