From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] app/testpmd: fix failsafe PMD failure on exit
Date: Tue, 22 May 2018 21:50:42 +0100
Message-ID: <ac26cad8-a784-d5f9-a395-976adaeffa00@intel.com>
References: <20180522183509.66644-1-ferruh.yigit@intel.com>
 <5833665.TREZe9cROF@xps> <25f03156-00a7-28ee-9519-6cb4262a83f7@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 dev@dpdk.org, Zhiyong Yang <zhiyong.yang@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 7AE0E11D4
 for <dev@dpdk.org>; Tue, 22 May 2018 22:50:46 +0200 (CEST)
In-Reply-To: <25f03156-00a7-28ee-9519-6cb4262a83f7@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/22/2018 9:49 PM, Ferruh Yigit wrote:
> On 5/22/2018 8:47 PM, Thomas Monjalon wrote:
>> 22/05/2018 20:35, Ferruh Yigit:
>>> vdevs detach on testpmd exit implemented as workaround to fix
>>> a virtio-user issue. The issue was virtio-user cleanup is not
>>> called and existing socket file not cleaned up which will fail
>>> next run.
>>>
>>> The vdev cleanup causing problems in failsafe PMD.
>>>
>>> Reduce the cleanup to only virtio-user and add a comment that this
>>> workaround should be converted to a proper cleanup, not something
>>> specific to virtio-user, and not something specific to vdev and
>>> testpmd.
>>>
>>> Fixes: fe890955114d ("app/testpmd: fix exit for vdevs")
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> OK to squash it with above patch.
> 
> Squashed into relevant commit in next-net, thanks.

Commit message updated after squash, @Zhiyong @Thomas please shout if something
is wrong in commit log.