From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/2] net/qede: fix performance bottleneck in Rx path Date: Fri, 18 Jan 2019 14:41:29 +0000 Message-ID: References: <20190118102930.27487-1-shshaikh@marvell.com> <16a3812b-8a4d-ba41-d5f4-0f80dd932a4d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: stable@dpdk.org, Rasesh Mody , Thomas Monjalon To: Shahed Shaikh , dev@dpdk.org Return-path: In-Reply-To: <16a3812b-8a4d-ba41-d5f4-0f80dd932a4d@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/18/2019 2:41 PM, Ferruh Yigit wrote: > On 1/18/2019 10:29 AM, Shahed Shaikh wrote: >> Allocating replacement buffer per received packet is expensive. >> Instead, process received packets first and allocate >> replacement buffers in bulk later. >> >> This improves performance by ~25% in terms of PPS on AMD >> platforms. >> >> Fixes: 2ea6f76aff40 ("qede: add core driver") >> Cc: stable@dpdk.org >> >> Signed-off-by: Shahed Shaikh > > Hi Shahed, > > This patch has been sent same day of the RC3, very close to the actual release, > and updating data path of the driver, so not a trivial patch. > > Although I tend to accept driver patches late in process this one was too late, > you won't have proper time to fix if any errors detected, but also I can see it > has a good amount performance effect. > > I would like to explicitly ask if you are willing to take the risk. If answer is > yes, please also be sure to get Rasesh's ack. cc'ed Thomas.