From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John Daley (johndale)" Subject: Re: [PATCH v2] net/enic: fix hardcoding of some flow director masks Date: Thu, 9 Feb 2017 17:43:59 +0000 Message-ID: References: <20170203095446.4614-1-johndale@cisco.com> <20170209004009.26242-1-johndale@cisco.com> <20170209004009.26242-2-johndale@cisco.com> <9bb15b91-a7a1-1bb7-478b-6b225b64b84d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: Ferruh Yigit Return-path: In-Reply-To: <9bb15b91-a7a1-1bb7-478b-6b225b64b84d@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com] > Sent: Thursday, February 09, 2017 2:16 AM > To: John Daley (johndale) > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [PATCH v2] net/enic: fix hardcoding of some flow director ma= sks >=20 > On 2/9/2017 12:40 AM, John Daley wrote: > > Hard coded mask values were being used for several of the IPv4 and > > IPv6 fields. Use the values in the rte_eth_fdir_masks structure > > provided by the caller. > > > > Fixes: dfbd6a9cb504 ("net/enic: extend flow director support for 1300 > > series") > > > > Cc: stable@dpdk.org > > Signed-off-by: John Daley > > --- > > > > v2: fix compile error >=20 > I wasn't getting an error for this. >=20 > V2 adds: >=20 > - ipv6_val.vtc_flow =3D input->flow.ipv6_flow.tc << 16; > + ipv6_val.vtc_flow =3D input->flow.ipv6_flow.tc << 12; >=20 > What is the compile error this fixes? This patch had the compile error: http://www.dpdk.org/dev/patchwork/patch/20147/ + ipv6_mask.vtc_flow =3D masks->ipv6_mask.tc << 16);