From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hunt, David" Subject: Re: [PATCH] checkpatches: don't assume bash syntax Date: Wed, 29 Aug 2018 09:56:12 +0100 Message-ID: References: <20180813154755.6313-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Stephen Hemminger , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 95999F11 for ; Wed, 29 Aug 2018 10:56:31 +0200 (CEST) In-Reply-To: <20180813154755.6313-1-stephen@networkplumber.org> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, On 13/8/2018 4:47 PM, Stephen Hemminger wrote: > The read -d option is a bash extension and not avaiable in other > shells. On Debian, /bin/sh is dash and checktpatches would > fail with: > ./devtools/checkpatches.sh: 52: read: Illegal option -d > > Fix by using awk -e and adding necessary double backslash. > > Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs") > Signed-off-by: Stephen Hemminger --snip-- The flavour of awk that's installed by default on Ubuntu is 'mawk' which does not seem to have a '-e' option. However, for anyone tryung to run checkpatch on Ubuntu with this patch, the quickest workaround is to install 'gawk', which does have the -e option, then this patch works great. Rgds, Dave.