From: Bruce Richardson <bruce.richardson@intel.com>
To: Shaiq Wani <shaiq.wani@intel.com>
Cc: <dev@dpdk.org>, <aman.deep.singh@intel.com>
Subject: Re: [PATCH v1] net/ice: fix FDIR flow type for tunnel inner items
Date: Wed, 25 Mar 2026 15:12:24 +0000 [thread overview]
Message-ID: <acP7WEglEU_AMLX3@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260323025418.651923-1-shaiq.wani@intel.com>
On Mon, Mar 23, 2026 at 08:24:18AM +0530, Shaiq Wani wrote:
> The inner_l3/inner_l4 tracking was introduced to handle L2TPv2 tunnel
> inner protocols separately from outer ones. However, the conditions used
> to branch into the inner tracking than specifically L2TPv2 tunnels.
>
> This caused VXLAN and GTPU FDIR rules with inner L3/L4 items to fail
> because the inner IPv4/IPv6/TCP/UDP/SCTP items no longer updated
> flow_type and l3, resulting in stale flow_type values.
>
> Fix by narrowing the inner protocol tracking conditions to only apply
> when tunnel_type is ICE_FDIR_TUNNEL_TYPE_L2TPV2.
>
> Fixes: 733640dae75e ("net/ice: support L2TPv2 flow pattern matching")
>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/ice/ice_fdir_filter.c | 34 ++++++++++++-------------
> 1 file changed, 16 insertions(+), 18 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2026-03-25 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 2:54 [PATCH v1] net/ice: fix FDIR flow type for tunnel inner items Shaiq Wani
2026-03-25 15:12 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acP7WEglEU_AMLX3@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox