[PATCH] net/ice: fix RSS LUT access for global LUT VSI

[PATCH] net/ice: fix RSS LUT access for global LUT VSI

[Vladimir Medvedkin]

When global RSS LUT is enabled, get/set RSS LUT still uses PF LUT
parameters in AQ commands, with lut_type set to PF and global_lut_id 0.
As a result, the operation may target the wrong LUT.

Use global LUT parameters when global LUT is allocated for the VSI,
and keep PF LUT parameters otherwise.

Fixes: 193a11ffd3e6 ("net/ice: adjust RSS LUT settings")
Cc: stable@dpdk.org

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 drivers/net/intel/ice/ice_ethdev.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/intel/ice/ice_ethdev.c b/drivers/net/intel/ice/ice_ethdev.c
index 8286816f06..0f2e7aee14 100644
--- a/drivers/net/intel/ice/ice_ethdev.c
+++ b/drivers/net/intel/ice/ice_ethdev.c
@@ -5479,9 +5479,10 @@ ice_get_rss_lut(struct ice_vsi *vsi, uint8_t *lut, uint16_t lut_size)
 	if (pf->flags & ICE_FLAG_RSS_AQ_CAPABLE) {
 		lut_params.vsi_handle = vsi->idx;
 		lut_params.lut_size = lut_size;
-		lut_params.lut_type = ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_PF;
+		lut_params.lut_type = (vsi->global_lut_allocated) ?
+			ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_GLOBAL : ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_PF;
 		lut_params.lut = lut;
-		lut_params.global_lut_id = 0;
+		lut_params.global_lut_id = (vsi->global_lut_allocated) ? vsi->global_lut_id : 0;
 		ret = ice_aq_get_rss_lut(hw, &lut_params);
 		if (ret) {
 			PMD_DRV_LOG(ERR, "Failed to get RSS lookup table");
@@ -5515,9 +5516,10 @@ ice_set_rss_lut(struct ice_vsi *vsi, uint8_t *lut, uint16_t lut_size)
 	if (pf->flags & ICE_FLAG_RSS_AQ_CAPABLE) {
 		lut_params.vsi_handle = vsi->idx;
 		lut_params.lut_size = lut_size;
-		lut_params.lut_type = ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_PF;
+		lut_params.lut_type = (vsi->global_lut_allocated) ?
+			ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_GLOBAL : ICE_AQC_GSET_RSS_LUT_TABLE_TYPE_PF;
 		lut_params.lut = lut;
-		lut_params.global_lut_id = 0;
+		lut_params.global_lut_id = (vsi->global_lut_allocated) ? vsi->global_lut_id : 0;
 		ret = ice_aq_set_rss_lut(hw, &lut_params);
 		if (ret) {
 			PMD_DRV_LOG(ERR, "Failed to set RSS lookup table");
-- 
2.43.0

Re: [PATCH] net/ice: fix RSS LUT access for global LUT VSI

[Bruce Richardson]

On Wed, Mar 25, 2026 at 04:39:58PM +0000, Vladimir Medvedkin wrote:
> When global RSS LUT is enabled, get/set RSS LUT still uses PF LUT
> parameters in AQ commands, with lut_type set to PF and global_lut_id 0.
> As a result, the operation may target the wrong LUT.
> 
> Use global LUT parameters when global LUT is allocated for the VSI,
> and keep PF LUT parameters otherwise.
> 
> Fixes: 193a11ffd3e6 ("net/ice: adjust RSS LUT settings")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH] net/ice: fix RSS LUT access for global LUT VSI

[Bruce Richardson]

On Fri, Mar 27, 2026 at 11:29:54AM +0000, Bruce Richardson wrote:
> On Wed, Mar 25, 2026 at 04:39:58PM +0000, Vladimir Medvedkin wrote:
> > When global RSS LUT is enabled, get/set RSS LUT still uses PF LUT
> > parameters in AQ commands, with lut_type set to PF and global_lut_id 0.
> > As a result, the operation may target the wrong LUT.
> > 
> > Use global LUT parameters when global LUT is allocated for the VSI,
> > and keep PF LUT parameters otherwise.
> > 
> > Fixes: 193a11ffd3e6 ("net/ice: adjust RSS LUT settings")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
Applied to next-net-intel.
Thanks,
/Bruce