Re: [PATCH] net/i40e: fix FDIR VLAN TCI partial mask validation

[Bruce Richardson <bruce.richardson@intel.com>]

On Mon, Mar 23, 2026 at 10:43:45AM +0000, Ciara Loftus wrote:
> Currently, the i40e flow validation logic accepts some partial VLAN TCI
> masks alongside the full mask, and reports an error for any other value.
> This is broken in two ways.
> 
> First, the error case is not handled correctly. An error is recorded
> however execution continues as normal, and a filter is programmed using
> the invalid mask, silently producing wrong matching behaviour.
> 
> Second, the hardware always compares the full 16-bit TCI field with no
> per-bit masking. Partial masks are therefore not honoured and should not
> be accepted.
> 
> Fix this by accepting only either a wildcard or exact match mask and
> handle the invalid mask cases appropriately.
> 
> Bugzilla ID: 1340
> Fixes: 81aebb47d1 ("net/i40e: fix flow director for eth + VLAN pattern")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  drivers/net/intel/i40e/i40e_flow.c | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-net-intel,

Thanks,
/Bruce