From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2] mbuf: rename deprecated VLAN flags Date: Wed, 25 Oct 2017 11:15:17 -0700 Message-ID: References: <20171023121623.27466-1-olivier.matz@6wind.com> <20171025151257.16459-1-olivier.matz@6wind.com> <4ae4cbe7-1ba9-90a2-c072-51f9ecb66e2d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: thomas@monjalon.net To: Olivier Matz , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6B1D41BA47 for ; Wed, 25 Oct 2017 20:15:18 +0200 (CEST) In-Reply-To: <4ae4cbe7-1ba9-90a2-c072-51f9ecb66e2d@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/25/2017 10:42 AM, Ferruh Yigit wrote: > On 10/25/2017 8:12 AM, Olivier Matz wrote: >> PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT are deprecated for a while. >> As explained in [1], these flags were kept to let the applications and >> PMDs move to the new flag. There is also a need to support Rx vlan >> offload without vlan strip (at least for the ixgbe driver). >> >> This patch renames the old flags for this feature, knowing that some >> PMDs were using PKT_RX_VLAN_PKT and PKT_RX_QINQ_PKT to indicate that >> the vlan tci has been saved in the mbuf structure. >> >> It is likely that some PMDs do not set the proper flags when doing vlan >> offload, and it would be worth making a pass on all of them. >> >> Link: [1] http://dpdk.org/ml/archives/dev/2017-June/067712.html >> Signed-off-by: Olivier Matz > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks. It may be good to stress this change in -rc2 announcement and ask for testing.