From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v5 3/3] net/vhost: vHost support to free consumed buffers Date: Wed, 1 Mar 2017 11:15:07 +0100 Message-ID: References: <20170123211340.22570-1-bmcfall@redhat.com> <20170127183800.27466-1-bmcfall@redhat.com> <20170127183800.27466-4-bmcfall@redhat.com> <1641551.cy8vlj4stG@xps13> <20170228064155.GM18844@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Billy McFall , wenzhuo.lu@intel.com, olivier.matz@6wind.com, dev@dpdk.org To: Yuanhan Liu , Thomas Monjalon Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 12D822BB1 for ; Wed, 1 Mar 2017 11:15:13 +0100 (CET) In-Reply-To: <20170228064155.GM18844@yliu-dev.sh.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/28/2017 07:41 AM, Yuanhan Liu wrote: > On Mon, Feb 27, 2017 at 02:50:54PM +0100, Thomas Monjalon wrote: >> 2017-01-27 13:38, Billy McFall: >>> Add support to the vHostdriver for the new API to force free consumed >>> buffers on Tx ring. vHost does not cache the mbufs so there is no work >>> to do. >>> >>> Signed-off-by: Billy McFall >> >> Yuanhan, Maxime, do you agree with this empty function? > > For this particular (vhost) implementation, I think it's okay. Agree with Yuanhan, it looks good for vhost case: Acked-by: Maxime Coquelin Thanks, Maxime