From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH v3] net/tap: fix isolation mode
	toggling
Date: Thu, 17 May 2018 15:13:40 +0100
Message-ID: <ad07f706-5eae-d6e4-cf50-bbe849dbf0c6@intel.com>
References: <1526335915-27693-1-git-send-email-ophirmu@mellanox.com>
 <1526336787-28457-1-git-send-email-ophirmu@mellanox.com>
 <88FE23C0-E7DB-4BB8-844B-4E77EC4D809F@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Pascal Mazon <pascal.mazon@6wind.com>,
 Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>,
 Shahaf Shuler <shahafs@mellanox.com>, "stable@dpdk.org" <stable@dpdk.org>
To: "Wiles, Keith" <keith.wiles@intel.com>, Ophir Munk <ophirmu@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <88FE23C0-E7DB-4BB8-844B-4E77EC4D809F@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/14/2018 11:46 PM, Wiles, Keith wrote:
> 
> 
>> On May 14, 2018, at 5:26 PM, Ophir Munk <ophirmu@mellanox.com> wrote:
>>
>> Running testpmd command "flow isolae <port> 0" (i.e. disabling flow
>> isolation) followed by command "flow isolate <port> 1" (i.e. enabling
>> flow isolation) may result in a TAP error:
>> PMD: Kernel refused TC filter rule creation (17): File exists
>>
>> Root cause analysis: when disabling flow isolation we keep the local
>> rule to redirect packets on TX (TAP_REMOTE_TX index) while we add it
>> again when enabling flow isolation. As a result this rule is added
>> two times in a row which results in "File exists" error.
>> The fix is to identify the "File exists" error and silently ignore it.
>>
>> Another issue occurs when enabling isolation mode several times in a
>> row in which case the same tc rules are added consecutively and
>> rte_flow structs are added to a linked list before removing the
>> previous rte_flow structs.
>> The fix is to act upon isolation mode command only when there is a
>> change from "0" to "1" (or vice versa).
>>
>> Fixes: f503d2694825 ("net/tap: support flow API isolated mode")
>> Cc: stable@dpdk.org
>>
>> Reviewed-by: Raslan Darawsheh <rasland@mellanox.com>
>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
>> —
> 
> Acked by: Keith Wiles<keith.wile@intel.com>

Applied to dpdk-next-net/master, thanks.