From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 04/15] crypto/caam_jr: add UIO specific
 operations
Date: Sun, 28 Oct 2018 01:35:13 +0100
Message-ID: <ad9849b7-6498-30df-ddb0-adb2e679e4e4@intel.com>
References: <20181022141657.4727-1-g.singh@nxp.com>
 <20181022145644.29277-1-g.singh@nxp.com>
 <20181022145644.29277-5-g.singh@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Gagandeep Singh <G.Singh@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Akhil Goyal <akhil.goyal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id A25E42965
 for <dev@dpdk.org>; Sun, 28 Oct 2018 02:35:16 +0200 (CEST)
In-Reply-To: <20181022145644.29277-5-g.singh@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/22/2018 3:57 PM, Gagandeep Singh wrote:
> caam_jr need support from kernel caam driver for
> job ring initialisation. So to access register space
> for job ring and allow re configure and map to userspace
> UIO interface is used. This also allows to handle the
> caam interrupts from the user space.
> 
> This patch adds UIO specific operations
> 
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

<...>

> +void
> +free_job_ring(uint32_t uio_fd)
> +{
> +	struct uio_job_ring *job_ring = NULL;
> +	int i;
> +
> +	if (!job_ring->uio_fd)
> +		return;

It seems this function is not called. Can the intention be:

 if (!uio_fd)
	 return;