From: Bruce Richardson <bruce.richardson@intel.com>
To: Lukas Sismis <sismis@dyna-nic.com>
Cc: <orika@nvidia.com>, <dev@dpdk.org>, <stephen@networkplumber.org>,
<thomas@monjalon.net>
Subject: Re: [PATCH v11 1/6] cmdline: include stddef.h for MSVC compatibility
Date: Wed, 15 Apr 2026 11:07:11 +0100 [thread overview]
Message-ID: <ad9jT-WdyIJOGRns@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <e6b37bf0359f847e14b84eeca3718e98cb6aaecd.1775850858.git.sismis@dyna-nic.com>
On Fri, Apr 10, 2026 at 10:15:39PM +0200, Lukas Sismis wrote:
> Include <stddef.h> at the top of cmdline_parse.h before the
> fallback offsetof macro definition. This improves MSVC build
> compatibility by ensuring the standard offsetof is available
> before the fallback definition, avoiding macro redefinition
> warnings when building with /WX (warnings as errors).
>
> The standard header provides offsetof on all platforms, and
> including it first ensures the fallback is only used when truly
> needed.
>
> Signed-off-by: Lukas Sismis <sismis@dyna-nic.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-04-15 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 20:15 [PATCH v11 0/6] flow_parser: add shared parser library Lukas Sismis
2026-04-10 20:15 ` [PATCH v11 1/6] cmdline: include stddef.h for MSVC compatibility Lukas Sismis
2026-04-15 10:07 ` Bruce Richardson [this message]
2026-04-10 20:15 ` [PATCH v11 2/6] ethdev: add RSS type helper APIs Lukas Sismis
2026-04-10 20:15 ` [PATCH v11 3/6] ethdev: add flow parser library Lukas Sismis
2026-04-10 20:15 ` [PATCH v11 4/6] app/testpmd: use flow parser from ethdev Lukas Sismis
2026-04-10 20:15 ` [PATCH v11 5/6] examples/flow_parsing: add flow parser demo Lukas Sismis
2026-04-10 20:15 ` [PATCH v11 6/6] test: add flow parser functional tests Lukas Sismis
2026-04-11 23:41 ` [PATCH v11 0/6] flow_parser: add shared parser library Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad9jT-WdyIJOGRns@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=sismis@dyna-nic.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox