From: Bruce Richardson <bruce.richardson@intel.com>
To: Jay Wang <Jay.Wang2@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Paul Szczepanek <Paul.Szczepanek@arm.com>,
Dhruv Tripathi <Dhruv.Tripathi@arm.com>
Subject: Re: [PATCH v3] net/ice: add NEON-optimised Rx/Tx vector paths
Date: Tue, 7 Apr 2026 17:12:44 +0100 [thread overview]
Message-ID: <adUs_MMCPqx5HpVD@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <PAWPR08MB94460AB72013149B1E1CFB66BA5AA@PAWPR08MB9446.eurprd08.prod.outlook.com>
On Tue, Apr 07, 2026 at 03:42:29PM +0000, Jay Wang wrote:
> Hi Bruce,
>
> I think it would be better to restrict compilation of the vectorised paths to AArch64 only.
> So, rather than modifying the intrinsics as I proposed earlier, I added an extra check in the meson build configuration file, as shown in the following code snippet.
> Could you please help verify the patch again? I also did a sanity check by cross building DPDK for AArch32 on my local AArch64 machine, and the file was not compiled, so no build errors were reported.
>
The CI should run this patch through the various builds and report the
output in patchwork. Once that goes clean I can consider merging the patch,
and if not, you can submit a v4.
> Sorry for duplicating the previous patches on the website. I've marked them as superseded.
>
No problem.
> Thanks,
> Jay Wang
>
> > diff --git a/drivers/net/intel/ice/meson.build b/drivers/net/intel/ice/meson.build
> > index 293577676f..a205304c89 100644
> > --- a/drivers/net/intel/ice/meson.build
> > +++ b/drivers/net/intel/ice/meson.build
> > @@ -33,6 +33,8 @@ endif
> > if arch_subdir == 'x86'
> > sources_avx2 += files('ice_rxtx_vec_avx2.c')
> > sources_avx512 += files('ice_rxtx_vec_avx512.c')
> > +elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
> > + sources += files('ice_rxtx_vec_neon.c')
> > endif
next prev parent reply other threads:[~2026-04-07 16:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 18:32 [PATCH v1 0/1] net/ice: add Neon-optimised Rx/Tx vector paths Jay Wang
2026-03-23 18:32 ` [PATCH v1 1/1] " Jay Wang
2026-03-24 16:25 ` [PATCH v1 0/1] net/ice: add NEON-optimised " Jay Wang
2026-03-24 16:25 ` [PATCH v1 1/1] net/ice: add Neon-optimised " Jay Wang
2026-03-24 16:25 ` [PATCH v2] net/ice: add NEON-optimised " Jay Wang
2026-04-03 14:33 ` Bruce Richardson
2026-04-07 10:47 ` Bruce Richardson
2026-04-07 13:41 ` Jay Wang
2026-04-07 15:12 ` [PATCH v1 0/1] " Jay Wang
2026-04-07 15:12 ` [PATCH v1 1/1] net/ice: add Neon-optimised " Jay Wang
2026-04-07 15:12 ` [PATCH v2] net/ice: add NEON-optimised " Jay Wang
2026-04-07 15:12 ` [PATCH v3] " Jay Wang
2026-04-07 15:42 ` Jay Wang
2026-04-07 16:12 ` Bruce Richardson [this message]
2026-04-09 10:29 ` Jay Wang
2026-04-08 16:45 ` Bruce Richardson
2026-04-09 16:41 ` [PATCH v4 0/1] " Jay Wang
2026-04-09 16:41 ` [PATCH v4 1/1] " Jay Wang
2026-03-24 10:51 ` [PATCH v1 0/1] net/ice: add Neon-optimised " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adUs_MMCPqx5HpVD@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Dhruv.Tripathi@arm.com \
--cc=Jay.Wang2@arm.com \
--cc=Paul.Szczepanek@arm.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox