* [PATCH] net/ice: add missing SMAC field mapping in flow input set
@ 2026-04-06 8:14 Shaiq Wani
2026-04-08 16:12 ` Bruce Richardson
2026-04-09 10:52 ` Bruce Richardson
0 siblings, 2 replies; 3+ messages in thread
From: Shaiq Wani @ 2026-04-06 8:14 UTC (permalink / raw)
To: dev, bruce.richardson, aman.deep.singh
ice_inset_map[] has no entry for ICE_INSET_SMAC, so source MAC is never
translated to ICE_FLOW_FIELD_IDX_ETH_SA. flow rules specifying a source
MAC silently match any source address.
Add the missing {ICE_INSET_SMAC, ICE_FLOW_FIELD_IDX_ETH_SA} entry.
Fixes: 733640dae75e ("net/ice: support L2TPv2 flow pattern matching")
Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
---
drivers/net/intel/ice/ice_fdir_filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
index 3522d77123..b3fdb1a9d7 100644
--- a/drivers/net/intel/ice/ice_fdir_filter.c
+++ b/drivers/net/intel/ice/ice_fdir_filter.c
@@ -967,6 +967,7 @@ ice_fdir_input_set_parse(uint64_t inset, enum ice_flow_field *field)
};
static const struct ice_inset_map ice_inset_map[] = {
{ICE_INSET_DMAC, ICE_FLOW_FIELD_IDX_ETH_DA},
+ {ICE_INSET_SMAC, ICE_FLOW_FIELD_IDX_ETH_SA},
{ICE_INSET_ETHERTYPE, ICE_FLOW_FIELD_IDX_ETH_TYPE},
{ICE_INSET_IPV4_SRC, ICE_FLOW_FIELD_IDX_IPV4_SA},
{ICE_INSET_IPV4_DST, ICE_FLOW_FIELD_IDX_IPV4_DA},
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/ice: add missing SMAC field mapping in flow input set
2026-04-06 8:14 [PATCH] net/ice: add missing SMAC field mapping in flow input set Shaiq Wani
@ 2026-04-08 16:12 ` Bruce Richardson
2026-04-09 10:52 ` Bruce Richardson
1 sibling, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2026-04-08 16:12 UTC (permalink / raw)
To: Shaiq Wani; +Cc: dev, aman.deep.singh
On Mon, Apr 06, 2026 at 01:44:39PM +0530, Shaiq Wani wrote:
> ice_inset_map[] has no entry for ICE_INSET_SMAC, so source MAC is never
> translated to ICE_FLOW_FIELD_IDX_ETH_SA. flow rules specifying a source
> MAC silently match any source address.
>
> Add the missing {ICE_INSET_SMAC, ICE_FLOW_FIELD_IDX_ETH_SA} entry.
>
> Fixes: 733640dae75e ("net/ice: support L2TPv2 flow pattern matching")
>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/ice/ice_fdir_filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
Recheck-request: iol-unit-arm64-testing, iol-intel-Functional, rebase=next-net-intel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/ice: add missing SMAC field mapping in flow input set
2026-04-06 8:14 [PATCH] net/ice: add missing SMAC field mapping in flow input set Shaiq Wani
2026-04-08 16:12 ` Bruce Richardson
@ 2026-04-09 10:52 ` Bruce Richardson
1 sibling, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2026-04-09 10:52 UTC (permalink / raw)
To: Shaiq Wani; +Cc: dev, aman.deep.singh
On Mon, Apr 06, 2026 at 01:44:39PM +0530, Shaiq Wani wrote:
> ice_inset_map[] has no entry for ICE_INSET_SMAC, so source MAC is never
> translated to ICE_FLOW_FIELD_IDX_ETH_SA. flow rules specifying a source
> MAC silently match any source address.
>
> Add the missing {ICE_INSET_SMAC, ICE_FLOW_FIELD_IDX_ETH_SA} entry.
>
> Fixes: 733640dae75e ("net/ice: support L2TPv2 flow pattern matching")
>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/ice/ice_fdir_filter.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-09 10:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-06 8:14 [PATCH] net/ice: add missing SMAC field mapping in flow input set Shaiq Wani
2026-04-08 16:12 ` Bruce Richardson
2026-04-09 10:52 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox