From: Bruce Richardson <bruce.richardson@intel.com>
To: Shaiq Wani <shaiq.wani@intel.com>
Cc: <dev@dpdk.org>, <aman.deep.singh@intel.com>
Subject: Re: [PATCH] net/intel: introduce a dedicated idpf complq struct
Date: Wed, 8 Apr 2026 16:29:14 +0100 [thread overview]
Message-ID: <adZ0SpRI9xkfBRBX@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260406044125.3170558-1-shaiq.wani@intel.com>
On Mon, Apr 06, 2026 at 10:11:25AM +0530, Shaiq Wani wrote:
> The IDPF split-queue completion queue was using ci_tx_queue, a structure
> designed for TX descriptor queues, wasting ~96 bytes per completion
> queue. Additionally, the CQ-only fields (compl_ring, txqs, tx_start_qid,
> expected_gen_id) bloated ci_tx_queue for every other Intel driver that
> shares it.
>
> Introduce struct idpf_complq with exactly the fields needed by the
> completion queue. This brings the CQ allocation down from ~150 bytes
> to ~48 bytes.
>
> Suggested-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
> drivers/net/intel/common/tx.h | 11 +++--------
> drivers/net/intel/cpfl/cpfl_ethdev.h | 2 +-
> drivers/net/intel/cpfl/cpfl_rxtx.c | 11 ++++++-----
> drivers/net/intel/idpf/idpf_common_rxtx.c | 4 ++--
> drivers/net/intel/idpf/idpf_common_rxtx.h | 16 +++++++++++++++-
> drivers/net/intel/idpf/idpf_common_rxtx_avx2.c | 4 ++--
> drivers/net/intel/idpf/idpf_common_rxtx_avx512.c | 4 ++--
> drivers/net/intel/idpf/idpf_rxtx.c | 2 +-
> 8 files changed, 32 insertions(+), 22 deletions(-)
>
Recheck-request: iol-unit-arm64-testing, iol-intel-Functional, rebase=next-net-intel
next prev parent reply other threads:[~2026-04-08 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 4:41 [PATCH] net/intel: introduce a dedicated idpf complq struct Shaiq Wani
2026-04-08 15:29 ` Bruce Richardson [this message]
2026-04-08 15:34 ` Bruce Richardson
2026-04-09 10:45 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adZ0SpRI9xkfBRBX@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox