public inbox for dev@dpdk.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Sergei Iashin <yashin.sergey@gmail.com>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Qiming Yang <qiming.yang@intel.com>, Ting Xu <ting.xu@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>, <dev@dpdk.org>,
	<stable@dpdk.org>
Subject: Re: [PATCH] net/iavf: remove dead code in TM node parameter check
Date: Wed, 8 Apr 2026 17:41:12 +0100	[thread overview]
Message-ID: <adaFKBRr2LlAyG51@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260407114730.1222526-1-yashin.sergey@gmail.com>

On Tue, Apr 07, 2026 at 02:47:30PM +0300, Sergei Iashin wrote:
> The non-leaf validation in iavf_node_param_check() unconditionally
> rejects a non-NULL wfq_weight_mode pointer at the top of the block.
> The else-if clause below re-tests the same pointer, which is guaranteed
> NULL at that point, making the branch unreachable dead code.
> 
> Remove the dead else-if block. No functional change.
> 
> Fixes: 44d0a720a538 ("net/iavf: query QoS capabilities and set queue TC mapping")
> Cc: ting.xu@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sergei Iashin <yashin.sergey@gmail.com>
> ---
>  drivers/net/intel/iavf/iavf_tm.c | 6 ------
>  1 file changed, 6 deletions(-)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-net-intel

Thanks,
/Bruce

      reply	other threads:[~2026-04-08 16:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07 11:47 [PATCH] net/iavf: remove dead code in TM node parameter check Sergei Iashin
2026-04-08 16:41 ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaFKBRr2LlAyG51@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=ting.xu@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yashin.sergey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox