From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2 5/5] net/virtio: improve offload check performance Date: Thu, 7 Jun 2018 09:22:13 +0200 Message-ID: References: <20180606123128.7868-1-maxime.coquelin@redhat.com> <20180606123128.7868-6-maxime.coquelin@redhat.com> <20180607045140.GA32696@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: zhihong.wang@intel.com, dev@dpdk.org To: Tiwei Bie Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 218E71559 for ; Thu, 7 Jun 2018 09:22:17 +0200 (CEST) In-Reply-To: <20180607045140.GA32696@debian> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/07/2018 06:51 AM, Tiwei Bie wrote: > On Wed, Jun 06, 2018 at 02:31:28PM +0200, Maxime Coquelin wrote: >> Instead of checking the multiple Virtio features bits for >> every packet, let's do the check once at configure time and >> store it in virtio_hw struct. >> >> Signed-off-by: Maxime Coquelin >> --- > [...] >> @@ -270,8 +261,7 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie, >> * which is wrong. Below subtract restores correct pkt size. >> */ >> cookie->pkt_len -= head_size; >> - /* if offload disabled, it is not zeroed below, do it now */ > > I think there is no need to remove this comment. Oh right, that was not intentional. Will add it again. > Apart from that, > > Reviewed-by: Tiwei Bie Thanks, Maxime >> - if (offload == 0) { >> + if (!vq->hw->has_tx_offload) { >> ASSIGN_UNLESS_EQUAL(hdr->csum_start, 0); >> ASSIGN_UNLESS_EQUAL(hdr->csum_offset, 0); >> ASSIGN_UNLESS_EQUAL(hdr->flags, 0); > [...] >