From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4 19/26] net/bnxt: add support for tx loopback, set vf mac and queues drop Date: Tue, 6 Jun 2017 13:53:02 +0100 Message-ID: References: <20170601030232.38677-1-ajit.khaparde@broadcom.com> <20170601170723.48709-1-ajit.khaparde@broadcom.com> <20170601170723.48709-20-ajit.khaparde@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Steeven Li To: Ajit Khaparde , dev@dpdk.org Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 80AB0532C for ; Tue, 6 Jun 2017 14:53:04 +0200 (CEST) In-Reply-To: <20170601170723.48709-20-ajit.khaparde@broadcom.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/1/2017 6:07 PM, Ajit Khaparde wrote: > Add functions rte_pmd_bnxt_set_tx_loopback, > rte_pmd_bnxt_set_all_queues_drop_en and > rte_pmd_bnxt_set_vf_mac_addr to configure tx_loopback, > queue_drop and VF MAC address setting in the hardware. > It also adds the necessary functions to send the HWRM commands > to the firmware. >>From the patch title it is clear that this patch add three different functionality. For this patchset, since it already went for a few releases I wouldn't mind, but for future, please send separate patches for each individual feature. Thanks, ferruh > > Signed-off-by: Steeven Li > Signed-off-by: Ajit Khaparde <...>