From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/mlx: remove link update lock Date: Mon, 16 Jan 2017 17:19:25 +0000 Message-ID: References: <1484153041-18034-1-git-send-email-olivier.matz@6wind.com> <20170116140323.GD3779@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Matthieu Ternisien d'Ouville To: Adrien Mazarguil , Olivier Matz Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0DB9E1094 for ; Mon, 16 Jan 2017 18:19:27 +0100 (CET) In-Reply-To: <20170116140323.GD3779@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/16/2017 2:03 PM, Adrien Mazarguil wrote: > On Wed, Jan 11, 2017 at 05:44:01PM +0100, Olivier Matz wrote: >> From: Matthieu Ternisien d'Ouville >> >> Retrieving link status information through the link update callback should >> be quick and non-blocking. >> >> Mellanox PMDs retrieve this information through ioctl() calls on the >> related kernel netdevice. This appears to take a long time to >> complete and may cause significant slowdowns in applications. >> >> While these system calls cannot be accelerated, removing the lock on the >> private structure allows applications to perform other control operations >> from separate threads in the meantime. This function remains safe without >> locking as it does not write the private structure, it is only used to >> retrieve the name of the netdevice. >> >> Signed-off-by: Matthieu Ternisien d'Ouville >> Signed-off-by: Olivier Matz >> --- >> drivers/net/mlx4/mlx4.c | 32 ++++++-------------------------- >> drivers/net/mlx5/mlx5.c | 2 +- >> drivers/net/mlx5/mlx5.h | 1 - >> drivers/net/mlx5/mlx5_ethdev.c | 30 ++++++------------------------ >> 4 files changed, 13 insertions(+), 52 deletions(-) > > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.