From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 1/2] net/failsafe: improve stats accuracy
Date: Mon, 23 Oct 2017 14:01:27 -0700
Message-ID: <aecddfe1-0c6f-6e5d-978d-bbbce23088a7@intel.com>
References: <1508423514-28557-1-git-send-email-matan@mellanox.com>
 <1508619286-7096-1-git-send-email-matan@mellanox.com>
 <20171023084613.GL3596@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= <gaetan.rivet@6wind.com>,
 Matan Azrad <matan@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 695931B6D2
 for <dev@dpdk.org>; Mon, 23 Oct 2017 23:02:18 +0200 (CEST)
In-Reply-To: <20171023084613.GL3596@bidouze.vm.6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/23/2017 1:46 AM, Gaëtan Rivet wrote:
> Thanks Matan,
> 
> On Sat, Oct 21, 2017 at 08:54:45PM +0000, Matan Azrad wrote:
>> The stats_get API was changed to signal a potential failure to read
>> stats. Furthermore, some PMDs are able to provide statistics even
>> after a removal event occurred.
>>
>> Considering this, the fail-safe can try to access the latest
>> statistics of a PMD to improve statistics accuracy.
>>
>> Attempt an ultimate statistics read on removal time; if that
>> fails, use the latest recorded snapshot.
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Series applied to dpdk-next-net/master, thanks.


(Fixed build error for 32bits [1] while applying, please check.)

[1]
.../dpdk/drivers/net/failsafe/failsafe_ether.c: In function ‘fs_dev_stats_save’:
.../dpdk/drivers/net/failsafe/failsafe_ether.c:328:50: error: format ‘%lu’
expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t
{aka long long unsigned int}’ [-Werror=format=]
      (rte_rdtsc() - timestamp) / rte_get_tsc_hz());
                                                  ^
.../dpdk/i686-native-linuxapp-gcc/include/rte_log.h:345:25: note: in definition
of macro ‘RTE_LOG’
    RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__)
                         ^
.../dpdk/drivers/net/failsafe/failsafe_private.h:299:26: note: in expansion of
macro ‘LOG__’
 #define LOG_(level, ...) LOG__(level, __VA_ARGS__, '\n')
                          ^~~~~
.../dpdk/drivers/net/failsafe/failsafe_private.h:302:19: note: in expansion of
macro ‘LOG_’
 #define WARN(...) LOG_(WARNING, __VA_ARGS__)
                   ^~~~
.../dpdk/drivers/net/failsafe/failsafe_ether.c:327:4: note: in expansion of
macro ‘WARN’
    WARN("Using latest snapshot taken before %lu seconds.\n",
    ^~~~