DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Daniil Iskhakov <dish@amicon.ru>
Cc: <dev@dpdk.org>, Andrey Chilikin <andrey.chilikin@intel.com>,
	Beilei Xing <beilei.xing@intel.com>, <stable@dpdk.org>,
	Daniil Agalakov <ade@amicon.ru>, <sdl.dpdk@linuxtesting.org>,
	<rrv@amicon.ru>
Subject: Re: [PATCH] net/i40e: validate DDP segment header before use
Date: Tue, 5 May 2026 16:43:16 +0100	[thread overview]
Message-ID: <afoQFEUOA2HEQL4P@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260427154401.1813519-1-dish@amicon.ru>

On Mon, Apr 27, 2026 at 06:44:01PM +0300, Daniil Iskhakov wrote:
> rte_pmd_i40e_get_ddp_info() retrieves the I40E segment header with
> i40e_find_segment_in_package(). That helper may return NULL if the
> segment cannot be found.
> 
> The returned pointer is validated only in one code path, while other
> branches use it without checking. This can lead to a NULL pointer
> dereference when parsing a malformed or incomplete DDP package.
> 
> Move the NULL check right before the segment usage so it applies to all
> request types needed.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: edeab742edac ("net/i40e: get information about DDP profile")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Daniil Agalakov <ade@amicon.ru>
> Signed-off-by: Daniil Iskhakov <dish@amicon.ru>
> ---

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-net-intel.

Thanks,
/Bruce

      reply	other threads:[~2026-05-05 15:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 15:44 [PATCH] net/i40e: validate DDP segment header before use Daniil Iskhakov
2026-05-05 15:43 ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afoQFEUOA2HEQL4P@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ade@amicon.ru \
    --cc=andrey.chilikin@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=dish@amicon.ru \
    --cc=rrv@amicon.ru \
    --cc=sdl.dpdk@linuxtesting.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox