From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH 2/2] net/ice: fix shaper profile reference count tracking
Date: Wed, 6 May 2026 16:40:54 +0100 [thread overview]
Message-ID: <afthBnLp-4p5ssjp@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260501105755.1136087-2-ciara.loftus@intel.com>
On Fri, May 01, 2026 at 10:57:55AM +0000, Ciara Loftus wrote:
> Currently, when a TM node is added with a shaper profile assigned,
> the profile's reference count is not incremented. Equally, when a node
> is deleted, the count is not decremented. As a result, the guard that
> blocks deletion of an in-use profile never triggers, allowing the profile
> to be freed while nodes still hold a pointer to it.
>
> Fix by maintaining the reference count correctly when nodes take or
> release a shaper profile, so that deletion of an in-use profile is
> properly rejected.
>
> Fixes: 8c481c3bb65b ("net/ice: support queue and queue group bandwidth limit")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
prev parent reply other threads:[~2026-05-06 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 10:57 [PATCH 1/2] net/ice: properly handle TM hierarchy deletion Ciara Loftus
2026-05-01 10:57 ` [PATCH 2/2] net/ice: fix shaper profile reference count tracking Ciara Loftus
2026-05-06 15:40 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afthBnLp-4p5ssjp@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox