DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Shaiq Wani <shaiq.wani@intel.com>
Cc: <dev@dpdk.org>, <aman.deep.singh@intel.com>
Subject: Re: [PATCH 3/6] net/idpf: fix mbuf initializer source in split queue AVX2 Rx
Date: Wed, 20 May 2026 13:21:53 +0100	[thread overview]
Message-ID: <ag2nYZb0d9CCY5C0@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260511090935.2288837-4-shaiq.wani@intel.com>

On Mon, May 11, 2026 at 02:39:32PM +0530, Shaiq Wani wrote:
> In split queue mode the completion queue (rxq) does not own the mbuf
> pool — the buffer queue (bufq2) does.  The mbuf initializer encodes
> the mempool pointer, refcount and other per-pool mbuf metadata that
> is stamped into every received mbuf during rearm.
> 
> Using queue->mbuf initializer reads an uninitialised or zero value
> from the completion queue, corrupting every mbuf rearm.  Use
> queue->bufq2->mbuf initializer to get the correct value from the
> buffer queue that actually owns the mbufs.
> 
> Fixes: 1f065f9d75ff ("net/idpf: add AVX2 Rx path for split queue config")
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  drivers/net/intel/idpf/idpf_common_rxtx_avx2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> index 28d4246134..d3a8e17778 100644
> --- a/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> +++ b/drivers/net/intel/idpf/idpf_common_rxtx_avx2.c
> @@ -491,7 +491,7 @@ idpf_dp_splitq_recv_pkts_avx2(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_
>  	struct rte_mbuf **sw_ring = &queue->bufq2->sw_ring[queue->rx_tail];
>  	volatile union virtchnl2_rx_desc *rxdp =
>  		(volatile union virtchnl2_rx_desc *)queue->rx_ring + queue->rx_tail;
> -	const __m256i mbuf_init = _mm256_set_epi64x(0, 0, 0, queue->mbuf_initializer);
> +	const __m256i mbuf_init = _mm256_set_epi64x(0, 0, 0, queue->bufq2->mbuf_initializer);
>  	uint64_t head_gen;
>  	uint16_t received = 0;
>  	int i;
> -- 
> 2.34.1
> 

  reply	other threads:[~2026-05-20 12:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  9:09 [PATCH 0/6] net/idpf: fix split queue AVX2 datapath Shaiq Wani
2026-05-11  9:09 ` [PATCH 1/6] net/idpf: fix gen bit extraction in split queue AVX2 Rx Shaiq Wani
2026-05-20 12:20   ` Bruce Richardson
2026-05-11  9:09 ` [PATCH 2/6] net/idpf: fix DD bit byte offset " Shaiq Wani
2026-05-20 12:21   ` Bruce Richardson
2026-05-11  9:09 ` [PATCH 3/6] net/idpf: fix mbuf initializer source " Shaiq Wani
2026-05-20 12:21   ` Bruce Richardson [this message]
2026-05-11  9:09 ` [PATCH 4/6] net/idpf: fix ptype insert position " Shaiq Wani
2026-05-20 12:22   ` Bruce Richardson
2026-05-11  9:09 ` [PATCH 5/6] net/idpf: fix split queue AVX2 Tx buffer size shift Shaiq Wani
2026-05-20 12:23   ` Bruce Richardson
2026-05-11  9:09 ` [PATCH 6/6] net/idpf: fix split queue AVX2 Tx burst and completion Shaiq Wani
2026-05-20 12:25   ` Bruce Richardson
2026-05-20 12:36 ` [PATCH 0/6] net/idpf: fix split queue AVX2 datapath Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ag2nYZb0d9CCY5C0@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=shaiq.wani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox