From: Bruce Richardson <bruce.richardson@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>
Cc: "Mandal, Anurag" <anurag.mandal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH v2] net/iavf: fix misleading AQ failure logging
Date: Tue, 9 Jun 2026 15:05:05 +0100 [thread overview]
Message-ID: <aigdkYk5JMBIZfPS@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <IA4PR11MB92781E302F372E466C89501C8E1D2@IA4PR11MB9278.namprd11.prod.outlook.com>
On Tue, Jun 09, 2026 at 01:30:47PM +0100, Loftus, Ciara wrote:
> > Subject: [PATCH v2] net/iavf: fix misleading AQ failure logging
> >
> > iavf_handle_virtchnl_msg() drains the admin receive queue in a loop
> > until iavf_clean_arq_element() reports that no descriptors are
> > pending. When the queue becomes empty, the base driver returns
> > IAVF_ERR_ADMIN_QUEUE_NO_WORK (-57), which is the documented
> > terminator for the drain loop, and is not an error.
> >
> > The current loop treats every non-IAVF_SUCCESS return as a failure
> > and logs it as follows:
> >
> > "Failed to read msg from AdminQ, ret: -57"
> >
> > This message floods the logs on every interrupt cycle and misleads
> > the triage during VF reset by chasing a real virtchnl problem
> > seeing these spurious -57 AQ failure lines in logs and assumes
> > the admin queue is broken, when in fact it has just been drained.
> >
> > This patch fixes the aforesaid issue by treating
> > IAVF_ERR_ADMIN_QUEUE_NO_WORK in virtchnl message drain as a normal
> > loop exit empty-queue condition and avoid logging it as an misleading
> > AQ failure.
> >
> > Fixes: 02d212ca3125 ("net/iavf: rename remaining avf strings")
Actually, I think the proper offending commit is earlier:
Fixes: 22b123a36d07 ("net/avf: initialize PMD")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
>
> Thanks Anurag.
>
> Acked-by: Ciara Loftus <ciara.loftus@intel.com>
>
Patch applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2026-06-09 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 17:15 [PATCH] net/iavf: fix misleading AQ failure logging Anurag Mandal
2026-06-09 8:13 ` Loftus, Ciara
2026-06-09 12:04 ` Mandal, Anurag
2026-06-09 12:00 ` [PATCH v2] " Anurag Mandal
2026-06-09 12:30 ` Loftus, Ciara
2026-06-09 14:05 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aigdkYk5JMBIZfPS@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anurag.mandal@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox