From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH v1 1/1] net/ice: fix NULL pointer dereference in DCF
Date: Fri, 26 Jun 2026 10:49:45 +0100 [thread overview]
Message-ID: <aj5LOTUlfWrwB1ZL@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <5fc2bdc0501a03687b4155cc847f89bb76687c0f.1782402538.git.anatoly.burakov@intel.com>
On Thu, Jun 25, 2026 at 04:49:08PM +0100, Anatoly Burakov wrote:
> When calling into common parameter checks and subsequent action check
> callbacks, the DCF path never supplied the `driver_ctx` struct, yet the
> callback itself dereferenced the struct.
>
> Fix it by supplying the DCF adapter struct as context.
>
> Fixes: db24a8092854 ("net/ice: use common action checks for switch")
> Cc: vladimir.medvedkin@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Patch applied to dpdk-next-net-intel.
Thanks,
/Bruce
> drivers/net/intel/ice/ice_switch_filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/intel/ice/ice_switch_filter.c b/drivers/net/intel/ice/ice_switch_filter.c
> index 5d9e0062af..6f5af03f6a 100644
> --- a/drivers/net/intel/ice/ice_switch_filter.c
> +++ b/drivers/net/intel/ice/ice_switch_filter.c
> @@ -1773,6 +1773,7 @@ ice_switch_parse_pattern_action(struct ice_adapter *ad,
> },
> .max_actions = 1,
> .check = ice_switch_dcf_action_check,
> + .driver_ctx = container_of(ad, struct ice_dcf_adapter, parent),
> };
> struct ci_flow_actions_check_param param = {
> .allowed_types = (enum rte_flow_action_type[]){
> --
> 2.47.3
>
prev parent reply other threads:[~2026-06-26 9:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 15:49 [PATCH v1 1/1] net/ice: fix NULL pointer dereference in DCF Anatoly Burakov
2026-06-26 9:49 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aj5LOTUlfWrwB1ZL@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox