From: Bruce Richardson <bruce.richardson@intel.com>
To: Maayan Kashani <mkashani@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
"stable@dpdk.org" <stable@dpdk.org>,
David Marchand <david.marchand@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] build: fix libpcap detection with unusable header
Date: Wed, 8 Jul 2026 08:54:56 +0100 [thread overview]
Message-ID: <ak4CUC045a0BVzMI@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <MW6PR12MB70707673C99F020A595212EBB2FF2@MW6PR12MB7070.namprd12.prod.outlook.com>
On Wed, Jul 08, 2026 at 06:37:59AM +0000, Maayan Kashani wrote:
> Hi, Bruce, we encountered DPDK build issue on Tencent 4.6. It is not
> expected; the package/image appears corrupted. RPM verification confirms
> the headers differ from the packaged contents. The DPDK change is still
> valid because optional dependency detection should test for usable
> declarations, not just file existence and library presence.”
>
I would disagree. Following that logic of checking for broken packages,
you're only handling a very small subset of that. If we start checking
this, we really should check for each and every definition in the file that
we need - otherwise we can still have issues with a broken package, for
example, it's broken in missing one definition that we need.
IMHO, in all these cases its better to let things fail, rather than working
around them, in order to prompt correction of the broken package.
/Bruce
prev parent reply other threads:[~2026-07-08 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 13:30 [PATCH] build: fix libpcap detection with unusable header Maayan Kashani
2026-07-07 14:16 ` Bruce Richardson
2026-07-08 6:37 ` Maayan Kashani
2026-07-08 7:11 ` Stephen Hemminger
2026-07-08 8:09 ` Maayan Kashani
2026-07-08 7:54 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak4CUC045a0BVzMI@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox