DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2] build: drop dependency on libbsd
Date: Mon, 29 Jun 2026 12:52:20 +0100	[thread overview]
Message-ID: <akJcdJ9beQ560Opd@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8yP-Mp75so4qoKqOHUzbgWqBi-e8JDLY6yZDpjhodU-tA@mail.gmail.com>

On Mon, Jun 29, 2026 at 01:30:32PM +0200, David Marchand wrote:
> On Thu, 25 Jun 2026 at 15:08, Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > Glibc added the strlcpy and strlcat functions to version 2.38, released
> > in 2023, meaning they are natively available in modern linux distros. At
> > this point, the value of having the libbsd provided versions of these
> > functions is reduced, so let's simplify the code options here by
> > providing just two options for strlcpy rather than three:
> >
> > 1. native implementation for BSD and recent Linux
> > 2. DPDK-specific fallbacks using snprintf
> >
> > Since the strlcpy and strlcat functions are the only two items used from
> > libbsd, we can then drop completely any DPDK dependency on libbsd.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> > ---
> > V2:
> > * took the work further than v1, dropping libbsd dependency entirely.
> >   Now DPDK just supports native strlcpy or it's own fallback version.
> 
> We still have some references:
> 
> $ git grep -i libbsd
> .github/workflows/build.yml:        libbsd-dev \
> .github/workflows/build.yml:        libbsd-devel \
> devtools/process-iwyu.py:def uses_libbsd(builddir):
> devtools/process-iwyu.py:    "return whether the build uses libbsd or not"
> devtools/process-iwyu.py:    return bool(get_build_config(builddir,
> lambda ln: 'RTE_USE_LIBBSD' in ln))
> devtools/process-iwyu.py:    keep_str_fns = uses_libbsd(build_dir)  #
> check for libbsd
> devtools/process-iwyu.py:        print("Warning: libbsd is present,
> build will fail to detect incorrect removal of rte_string_fns.h",
> doc/guides/howto/af_xdp_dp.rst:          libbsd-devel \
> 

Sure, will respin and try and clean these up a bit. I assume from the
detailed feedback that there is no issue with the high-level approach here?

/Bruce

  reply	other threads:[~2026-06-29 11:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24 11:35 [PATCH] build: use native Linux strlcpy when available Bruce Richardson
2026-06-25 13:08 ` [PATCH v2] build: drop dependency on libbsd Bruce Richardson
2026-06-29 11:30   ` David Marchand
2026-06-29 11:52     ` Bruce Richardson [this message]
2026-06-29 11:55       ` David Marchand
2026-06-29 14:29 ` [PATCH v3] " Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akJcdJ9beQ560Opd@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox