From: Bruce Richardson <bruce.richardson@intel.com>
To: Shuzo Ichiyoshi <deadcafe.beef@gmail.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH 1/2] net/e1000: fix igc RSS redirection table
Date: Mon, 29 Jun 2026 16:21:26 +0100 [thread overview]
Message-ID: <akKNdk8s7O17S9m1@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260629045511.473850-1-deadcafe.beef@gmail.com>
On Mon, Jun 29, 2026 at 01:51:13PM +0900, Shuzo Ichiyoshi wrote:
> The IGC RETA register stores four 8-bit queue indexes.
> igc_rss_configure() and igc_add_rss_filter() used a fresh
> uninitialized union for each table entry and wrote the register only
> every fourth entry. As a result, three bytes of each RETA register
> came from stack garbage.
>
> Build the register a word at a time and initialize all four queue
> indexes before writing it.
>
> Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx")
> Fixes: 746664d546fb ("net/igc: support flow API")
> Cc: stable@dpdk.org
> Signed-off-by: Shuzo Ichiyoshi <deadcafe.beef@gmail.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-06-29 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 4:51 [PATCH 1/2] net/e1000: fix igc RSS redirection table Shuzo Ichiyoshi
2026-06-29 4:51 ` [PATCH 2/2] net/e1000: fix igc Tx descriptor ring wrap Shuzo Ichiyoshi
2026-06-29 5:59 ` Song, Yoong Siang
2026-06-29 15:27 ` Bruce Richardson
2026-06-29 15:21 ` Bruce Richardson [this message]
2026-06-29 15:50 ` [PATCH 1/2] net/e1000: fix igc RSS redirection table Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akKNdk8s7O17S9m1@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=deadcafe.beef@gmail.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox