DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anurag Mandal <anurag.mandal@intel.com>
Cc: <dev@dpdk.org>, <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH] doc: announce QinQ offloading operations in iavf PMD
Date: Mon, 6 Jul 2026 12:09:11 +0100	[thread overview]
Message-ID: <akuM15sJlImRdy6s@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260704131730.457722-1-anurag.mandal@intel.com>

On Sat, Jul 04, 2026 at 01:17:30PM +0000, Anurag Mandal wrote:
> The iavf PMD supports hardware offloading for all QinQ operations.
> QinQ tag stripping and insertion offloads have been added for both
> outer VLAN TPIDs: 0x88a8 (IEEE 802.1ad) & 0x8100 (IEEE 802.1Q).
> 
> Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
> ---
>  doc/guides/nics/features/iavf.ini      | 2 +-
>  doc/guides/rel_notes/release_26_07.rst | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
> index 0ba6f7dfd7..e324a7aecb 100644
> --- a/doc/guides/nics/features/iavf.ini
> +++ b/doc/guides/nics/features/iavf.ini
> @@ -30,7 +30,7 @@ Traffic manager      = Y
>  Inline crypto        = P
>  CRC offload          = Y
>  VLAN offload         = P
> -QinQ offload         = P
> +QinQ offload         = Y

Not sure we can advertise full support. Checking with AI it seems we have
some gaps, for example, the legacy (non-flex) descriptor scalar Rx - used
with X710 NICs for example - doesn't support reading two tags for QinQ
strip.

>  L3 checksum offload  = Y
>  L4 checksum offload  = Y
>  Timestamp offload    = Y
> diff --git a/doc/guides/rel_notes/release_26_07.rst b/doc/guides/rel_notes/release_26_07.rst
> index cf79eb57bf..d864019244 100644
> --- a/doc/guides/rel_notes/release_26_07.rst
> +++ b/doc/guides/rel_notes/release_26_07.rst
> @@ -139,6 +139,7 @@ New Features
>  
>    * Added support for transmitting LLDP packets based on mbuf packet type.
>    * Implemented AVX2 context descriptor transmit paths.
> +  * Added support for QinQ offloading operations.

Can we tighten this statement up a bit - "Added support for Tx QinQ
offload", to make it clear that it's only the Tx side support has changed
in this release?

>  
>  * **Updated Intel ice driver.**
>  
> -- 
> 2.34.1
> 

  reply	other threads:[~2026-07-06 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-04 13:17 [PATCH] doc: announce QinQ offloading operations in iavf PMD Anurag Mandal
2026-07-06 11:09 ` Bruce Richardson [this message]
2026-07-06 13:24   ` Mandal, Anurag
2026-07-06 13:34 ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akuM15sJlImRdy6s@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anurag.mandal@intel.com \
    --cc=dev@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox