From: Bruce Richardson <bruce.richardson@intel.com>
To: <sandeep.penigalapati@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] net/ice: fix missing return on unsupported range in FDIR
Date: Mon, 13 Jul 2026 10:27:07 +0100 [thread overview]
Message-ID: <alSuwXCSpecgJGn7@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260712032647.196461-1-sandeep.penigalapati@intel.com>
On Sat, Jul 11, 2026 at 11:26:47PM -0400, sandeep.penigalapati@intel.com wrote:
> From: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
>
> In ice_fdir_parse_pattern(), a flow item that specifies a 'last'
> member (a range) is only allowed for IPV4 and IPV6_FRAG_EXT item
> types. For other item types the code set an rte_flow error but did
> not return, so parsing continued from an inconsistent state.
>
> Add the missing return so an unsupported range aborts parsing.
>
> Fixes: b7e8781de768 ("net/ice: support flow director for IP fragment packet")
> Cc: stable@dpdk.org
>
> Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Trivial fix, ok for RC4.
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
> ---
> drivers/net/intel/ice/ice_fdir_filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
> index fc848a33db..d7ddd32f90 100644
> --- a/drivers/net/intel/ice/ice_fdir_filter.c
> +++ b/drivers/net/intel/ice/ice_fdir_filter.c
> @@ -1929,6 +1929,7 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ITEM, item,
> "Not support range");
> + return -rte_errno;
> }
>
> input_set = (tunnel_type && !is_outer) ?
> --
> 2.27.0
>
prev parent reply other threads:[~2026-07-13 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 3:26 [PATCH] net/ice: fix missing return on unsupported range in FDIR sandeep.penigalapati
2026-07-13 9:27 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alSuwXCSpecgJGn7@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sandeep.penigalapati@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox