From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Daniels Subject: Re: [PATCH] net/ixgbe: prevent duplicate callback on list Date: Wed, 19 Oct 2016 22:11:25 -0400 (EDT) Message-ID: References: <1476915787-28205-1-git-send-email-daniels@research.att.com> <1476915787-28205-2-git-send-email-daniels@research.att.com> <6A0DE07E22DDAD4C9103DF62FEBC09093933D40B@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Cc: "Zhang, Helin" , "Iremonger, Bernard" , "dev@dpdk.org" , "ZELEZNIAK, ALEX" To: "Lu, Wenzhuo" Return-path: Received: from mx0a-00191d01.pphosted.com (mx0a-00191d01.pphosted.com [67.231.149.140]) by dpdk.org (Postfix) with ESMTP id 879C52C01 for ; Thu, 20 Oct 2016 04:11:55 +0200 (CEST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093933D40B@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 19 Oct 2016, Lu, Wenzhuo wrote: > Hi Scott, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of E. Scott Daniels >> Sent: Thursday, October 20, 2016 6:23 AM >> To: Zhang, Helin; Iremonger, Bernard >> Cc: dev@dpdk.org; az5157@att.com; E. Scott Daniels >> Subject: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list >> >> This change prevents the attempt to add a structure which is already on the >> callback list. If a struct with matching parameters is found on the list, then no >> action is taken. If a struct with matching parameters is found on the list, then no >> action is taken. >> >> Signed-off-by: E. Scott Daniels > I think the fix itself is good. But 2 things, > 1, normally we don't create a cover letter for a patch set which only has one patch. Just sending the patch itself is enough. > 2, ' net/ixgbe: ' in the title is used to describe the component. So the title should be ' lib/ether: prevent duplicate callback on list'. > Thanks. Thanks for the advice. My mistake on the component. Is there an easy way to fix, or does it make sense just to nack this and I'll submit one with the correct component. Scott > >