From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Anatoly Burakov" <anatoly.burakov@intel.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Reshma Pattan" <reshma.pattan@intel.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Subject: Re: [PATCH v2 7/9] test: limit internal API usage
Date: Thu, 23 Jul 2026 14:33:33 +0100 [thread overview]
Message-ID: <amIYLQNKLnMPgHZf@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260723125559.3087579-8-david.marchand@redhat.com>
On Thu, Jul 23, 2026 at 02:55:56PM +0200, David Marchand wrote:
> Internal APIs may be used for validating the internals of some
> component, but in general, it should be discouraged.
>
> Let's not allow globally internal API in the unit tests.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> app/test/meson.build | 3 ---
> app/test/process.c | 2 ++
> app/test/test_devargs.c | 2 ++
> app/test/test_external_mem.c | 2 ++
> app/test/test_malloc.c | 2 ++
> app/test/test_mempool.c | 2 ++
> app/test/test_pdump.c | 3 +++
> app/test/virtual_pmd.c | 2 ++
> 8 files changed, 15 insertions(+), 3 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-07-23 13:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 9:29 [PATCH 00/10] Limit usage of internal API in tests David Marchand
2026-07-17 9:29 ` [PATCH 01/10] bbdev: fix stats aggregation from queues David Marchand
2026-07-17 17:22 ` Chautru, Nicolas
2026-07-18 7:47 ` David Marchand
2026-07-17 9:29 ` [PATCH 02/10] bbdev: add per-queue statistics API David Marchand
2026-07-17 9:29 ` [PATCH 03/10] hash: fix GFNI stubs export David Marchand
2026-07-17 9:38 ` Bruce Richardson
2026-07-17 9:55 ` Konstantin Ananyev
2026-07-17 9:29 ` [PATCH 04/10] test: uninline helper for forking David Marchand
2026-07-17 9:39 ` Bruce Richardson
2026-07-17 9:30 ` [PATCH 05/10] test/bonding: get MAC address with public API David Marchand
2026-07-17 9:30 ` [PATCH 06/10] test/devargs: check driver presence " David Marchand
2026-07-17 9:55 ` Bruce Richardson
2026-07-17 10:08 ` David Marchand
2026-07-17 10:14 ` Bruce Richardson
2026-07-17 12:34 ` David Marchand
2026-07-17 12:56 ` Thomas Monjalon
2026-07-17 9:30 ` [PATCH 07/10] test/vdev: find device " David Marchand
2026-07-17 9:30 ` [PATCH 08/10] test: limit internal API usage David Marchand
2026-07-17 9:30 ` [PATCH 09/10] ci: make ABI reference generation faster David Marchand
2026-07-17 9:30 ` [PATCH 10/10] ci: run reference unit tests against ABI David Marchand
2026-07-17 9:35 ` [PATCH 00/10] Limit usage of internal API in tests David Marchand
2026-07-23 12:55 ` [PATCH v2 0/9] " David Marchand
2026-07-23 12:55 ` [PATCH v2 1/9] bbdev: add per-queue statistics API David Marchand
2026-07-23 12:55 ` [PATCH v2 2/9] hash: fix GFNI stubs export David Marchand
2026-07-23 12:55 ` [PATCH v2 3/9] test: uninline helper for forking David Marchand
2026-07-23 12:55 ` [PATCH v2 4/9] test/bonding: get MAC address with public API David Marchand
2026-07-23 13:30 ` Bruce Richardson
2026-07-23 12:55 ` [PATCH v2 5/9] test/devargs: rely on net null driver David Marchand
2026-07-23 13:31 ` Bruce Richardson
2026-07-23 12:55 ` [PATCH v2 6/9] test/vdev: find device with public API David Marchand
2026-07-23 12:55 ` [PATCH v2 7/9] test: limit internal API usage David Marchand
2026-07-23 13:33 ` Bruce Richardson [this message]
2026-07-23 15:04 ` Morten Brørup
2026-07-23 12:55 ` [PATCH v2 8/9] ci: make ABI reference generation faster David Marchand
2026-07-23 12:55 ` [PATCH v2 9/9] ci: run reference binaries against current ABI David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amIYLQNKLnMPgHZf@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox