dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2 2/2] net/iavf: rename LLDP Tx devarg
Date: Fri, 14 Aug 2026 14:08:31 +0100	[thread overview]
Message-ID: <an8TT88vvHUfTjXM@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260814123753.2041645-2-ciara.loftus@intel.com>

On Fri, Aug 14, 2026 at 12:37:53PM +0000, Ciara Loftus wrote:
> Now that the dynamic mbuf field method has been removed, packet type is
> the only mechanism used to detect LLDP packets on the transmit path.
> Using the word 'ptype' in the 'enable_ptype_lldp' devarg is therefore
> unnecessary and an implementation detail that no longer needs to be
> exposed to users.
> 
> Rename the devarg to 'enable_lldp'. The old 'enable_ptype_lldp' name is
> rejected with an error directing the user to the new name. This is
> considered safe because the old devarg name only featured in one
> release.
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
> * Hard fail instead of warning when old devarg is used
> ---
>  doc/guides/nics/intel_vf.rst           |  9 +++++++--
>  doc/guides/rel_notes/release_26_11.rst |  7 ++++++-
>  drivers/net/intel/iavf/iavf.h          |  2 +-
>  drivers/net/intel/iavf/iavf_ethdev.c   | 17 +++++++++++++----
>  drivers/net/intel/iavf/iavf_rxtx.c     |  2 +-
>  5 files changed, 28 insertions(+), 9 deletions(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2026-08-14 13:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 14:03 [PATCH 1/2] net/iavf: remove Tx LLDP dynfield method Ciara Loftus
2026-08-10 14:03 ` [PATCH 2/2] net/iavf: rename LLDP Tx devarg Ciara Loftus
2026-08-13 15:50   ` Bruce Richardson
2026-08-14 12:44     ` Loftus, Ciara
2026-08-13 15:30 ` [PATCH 1/2] net/iavf: remove Tx LLDP dynfield method Bruce Richardson
2026-08-14 12:37 ` [PATCH v2 " Ciara Loftus
2026-08-14 12:37   ` [PATCH v2 2/2] net/iavf: rename LLDP Tx devarg Ciara Loftus
2026-08-14 13:08     ` Bruce Richardson [this message]
2026-08-14 15:08   ` [PATCH v2 1/2] net/iavf: remove Tx LLDP dynfield method Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an8TT88vvHUfTjXM@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).