From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v2 1/2] net/i40e: do not use flow RSS conf struct
Date: Fri, 21 Aug 2026 17:11:25 +0100 [thread overview]
Message-ID: <aoh4ramhYPg0JA38@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <f7d315f9310b362e46e7a1e342ed20b6576d347e.1787303683.git.anatoly.burakov@intel.com>
On Fri, Aug 21, 2026 at 10:15:30AM +0100, Anatoly Burakov wrote:
> Currently, the RSS filter structure includes an rte_flow RSS conf structure
> directly. This is suboptimal, because that structure has pointers in it,
> which makes copying data out of this structure a non-trivial operation that
> may introduce potentially dangling pointers to queue lists or RSS key.
>
> Replace it with direct members of the RSS config struct, and adjust all
> users accordingly.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> drivers/net/intel/i40e/i40e_ethdev.h | 11 +++++---
> drivers/net/intel/i40e/i40e_flow.c | 13 +++++++---
> drivers/net/intel/i40e/i40e_hash.c | 39 ++++++++++++----------------
> drivers/net/intel/i40e/i40e_hash.h | 1 -
> 4 files changed, 33 insertions(+), 31 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-08-21 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 14:23 [PATCH v1 0/2] I40E refactors Anatoly Burakov
2026-08-19 14:23 ` [PATCH v1 1/2] net/i40e: do not use flow RSS conf struct Anatoly Burakov
2026-08-19 14:23 ` [PATCH v1 2/2] net/i40e: move mutable fields out of RSS config Anatoly Burakov
2026-08-21 9:15 ` [PATCH v2 0/2] I40E refactors Anatoly Burakov
2026-08-21 9:15 ` [PATCH v2 1/2] net/i40e: do not use flow RSS conf struct Anatoly Burakov
2026-08-21 16:11 ` Bruce Richardson [this message]
2026-08-21 9:15 ` [PATCH v2 2/2] net/i40e: move mutable fields out of RSS config Anatoly Burakov
2026-08-21 16:24 ` Bruce Richardson
2026-08-21 16:36 ` [PATCH v2 0/2] I40E refactors Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoh4ramhYPg0JA38@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox