From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Anatoly Burakov <anatoly.burakov@intel.com>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH 7/8] net/ixgbe: move editable files out of base folder
Date: Mon, 24 Aug 2026 17:35:55 +0100 [thread overview]
Message-ID: <aoxy6_XNdpBkZHQ7@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8zYSCsbKBJPYc_bH-QhJoZff+vU-va5Po5NJbptX9Q9qA@mail.gmail.com>
On Mon, Aug 24, 2026 at 06:23:22PM +0200, David Marchand wrote:
> On Fri, 14 Aug 2026 at 17:39, Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> > diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> > index 3d4f4fb7fc..8e44bb3a09 100644
> > --- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
> > @@ -36,15 +36,15 @@
> > #include <rte_os_shim.h>
> >
> > #include "ixgbe_logs.h"
> > -#include "base/ixgbe_api.h"
> > -#include "base/ixgbe_vf.h"
> > -#include "base/ixgbe_common.h"
> > +#include "ixgbe_api.h"
> > +#include "ixgbe_vf.h"
> > +#include "ixgbe_common.h"
> > #include "ixgbe_ethdev.h"
> > #include "ixgbe_bypass.h"
> > #include "ixgbe_rxtx.h"
> > -#include "base/ixgbe_type.h"
> > -#include "base/ixgbe_phy.h"
> > -#include "base/ixgbe_osdep.h"
> > +#include "ixgbe_type.h"
> > +#include "ixgbe_phy.h"
> > +#include "ixgbe_osdep.h"
> > #include "ixgbe_regs.h"
>
> While I agree with the base/ixgbe_osdep.h -> ixgbe_osdep.h conversion,
> I don't get why you *need* to change other base headers inclusions
> above.
>
> The rest of the series looks good to me.
>
I don't need to, I just felt that the base specifiers were unnecessary.
I'll revert those changes, though, to keep all files consistent in this
driver.
/Bruce
next prev parent reply other threads:[~2026-08-24 16:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 15:37 [PATCH 0/8] remove non-base files from base folders Bruce Richardson
2026-08-14 15:37 ` [PATCH 1/8] net/e1000: move editable files out of base folder Bruce Richardson
2026-08-14 15:37 ` [PATCH 2/8] net/fm10k: " Bruce Richardson
2026-08-14 15:37 ` [PATCH 3/8] net/i40e: " Bruce Richardson
2026-08-14 15:37 ` [PATCH 4/8] net/iavf: " Bruce Richardson
2026-08-14 15:37 ` [PATCH 5/8] net/ice: " Bruce Richardson
2026-08-14 15:37 ` [PATCH 6/8] net/idpf: " Bruce Richardson
2026-08-14 15:37 ` [PATCH 7/8] net/ixgbe: " Bruce Richardson
2026-08-24 16:23 ` David Marchand
2026-08-24 16:35 ` Bruce Richardson [this message]
2026-08-14 15:37 ` [PATCH 8/8] net/ice: consolidate the sources list Bruce Richardson
2026-08-25 13:38 ` [PATCH 0/8] remove non-base files from base folders Burakov, Anatoly
2026-08-25 15:15 ` [PATCH v2 " Bruce Richardson
2026-08-25 15:15 ` [PATCH v2 1/8] net/e1000: move editable files out of base folder Bruce Richardson
2026-08-25 15:15 ` [PATCH v2 2/8] net/fm10k: " Bruce Richardson
2026-08-25 15:15 ` [PATCH v2 3/8] net/i40e: " Bruce Richardson
2026-08-25 15:15 ` [PATCH v2 4/8] net/iavf: " Bruce Richardson
2026-08-25 15:15 ` [PATCH v2 5/8] net/ice: " Bruce Richardson
2026-08-25 15:15 ` [PATCH v2 6/8] net/idpf: " Bruce Richardson
2026-08-25 15:15 ` [PATCH v2 7/8] net/ixgbe: " Bruce Richardson
2026-08-25 15:15 ` [PATCH v2 8/8] net/ice: consolidate the sources list Bruce Richardson
2026-08-25 15:54 ` [PATCH v2 0/8] remove non-base files from base folders David Marchand
2026-08-25 16:03 ` Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 " Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 1/8] net/e1000: move editable files out of base folder Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 2/8] net/fm10k: " Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 3/8] net/i40e: " Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 4/8] net/iavf: " Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 5/8] net/ice: " Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 6/8] net/idpf: " Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 7/8] net/ixgbe: " Bruce Richardson
2026-08-25 16:27 ` [PATCH v3 8/8] net/ice: consolidate the sources list Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoxy6_XNdpBkZHQ7@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox