From: Bruce Richardson <bruce.richardson@intel.com>
To: Marat Khalili <marat.khalili@huawei.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] cmdline: add cmdline_ prefix to dprintf
Date: Tue, 8 Sep 2026 11:18:26 +0100 [thread overview]
Message-ID: <ap_g8oAzdlRSd3d6@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260908101534.71961-1-marat.khalili@huawei.com>
On Tue, Sep 08, 2026 at 11:15:34AM +0100, Marat Khalili wrote:
> Macro `dprintf` defined in `cmdline_cirbuf.h` may clash with eponymous
> glibc macro. Add `cmdline_` prefix to the one defined by DPDK.
>
> Signed-off-by: Marat Khalili <marat.khalili@huawei.com>
> ---
> lib/cmdline/cmdline.c | 2 +-
> lib/cmdline/cmdline_cirbuf.c | 28 ++++++++++++++--------------
> lib/cmdline/cmdline_cirbuf.h | 6 +++---
> lib/cmdline/cmdline_socket.c | 2 +-
> 4 files changed, 19 insertions(+), 19 deletions(-)
>
Strange that we have never hit this issue before, but good fix.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-09-08 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 10:15 [PATCH] cmdline: add cmdline_ prefix to dprintf Marat Khalili
2026-09-08 10:18 ` Bruce Richardson [this message]
2026-09-08 11:37 ` Konstantin Ananyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap_g8oAzdlRSd3d6@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=marat.khalili@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox