From: Bruce Richardson <bruce.richardson@intel.com>
To: Hailin Xu <hailinx.xu@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v1] nics: add E2200 to the NIC guide
Date: Fri, 18 Sep 2026 12:02:59 +0100 [thread overview]
Message-ID: <aq0aYyj9MWOnkdnW@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <an766BU0CW0bKY7t@bricha3-mobl1.ger.corp.intel.com>
On Fri, Aug 14, 2026 at 12:24:24PM +0100, Bruce Richardson wrote:
> On Wed, Aug 12, 2026 at 10:09:07AM +0800, Hailin Xu wrote:
> > nics/cpfl: add E2200 to cpfi nics/idpf: add E2200 to idpf
> >
>
> Needs a proper text description. The commit title probably should start
> with "doc" or "doc/nics" rather than just "doc".
>
> > Signed-off-by: Hailin Xu <hailinx.xu@intel.com> ---
> > doc/guides/nics/cpfl.rst | 1 + doc/guides/nics/idpf.rst | 2 +- 2 files
> > changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst index
> > 3e2788ba03..5964a980ee 100644 --- a/doc/guides/nics/cpfl.rst +++
> > b/doc/guides/nics/cpfl.rst @@ -8,6 +8,7 @@ CPFL Poll Mode Driver
> >
> > The cpfl PMD (**librte_net_cpfl**) provides poll mode driver support
> > for Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU)
> > E2100. +Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg|
> > IPU) E2200.
>
> Since this is not a bulleted list or similar, best to add an "and" in
> between the two NIC names.
>
> > Please refer to
> > https://www.intel.com/content/www/us/en/products/network-io/infrastructure-processing-units/asic/e2000-asic.html
> > for more information. diff --git a/doc/guides/nics/idpf.rst
> > b/doc/guides/nics/idpf.rst index f4cd69ba7d..1f06eed645 100644 ---
> > a/doc/guides/nics/idpf.rst +++ b/doc/guides/nics/idpf.rst @@ -8,7 +8,7
> > @@ IDPF Poll Mode Driver
> >
> > The idpf PMD (**librte_net_idpf**) provides poll mode driver support
> > for Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg| IPU)
> > E2100. - +Intel\ |reg| Infrastructure Processing Unit (Intel\ |reg|
> > IPU) E2200.
> >
>
> Similarly here. However, I think in this case you probably want to keep
> the two blank lines at end of the section i.e. just adding a new line
> rather than replacing a blank line with the new text.
>
> > Linux Prerequisites ------------------- -- 2.34.1
> >
Rather than waiting further for a v2, I've made the necessary changes on
apply and added my own signoff (in addition to original author) to this
patch too.
Patch now applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2026-09-18 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 2:09 [PATCH v1] nics: add E2200 to the NIC guide Hailin Xu
2026-08-14 11:24 ` Bruce Richardson
2026-09-18 11:02 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq0aYyj9MWOnkdnW@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hailinx.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox