From: Bruce Richardson <bruce.richardson@intel.com>
To: Anurag Mandal <anurag.mandal@intel.com>
Cc: <dev@dpdk.org>, <anatoly.burakov@intel.com>
Subject: Re: [PATCH 0/2] net/ice: fix memory handling issues
Date: Wed, 7 Oct 2026 10:31:43 +0100 [thread overview]
Message-ID: <asYRf0mgWZu8sUmi@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <cover.1791356190.git.anurag.mandal@intel.com>
On Wed, Oct 07, 2026 at 07:58:18AM +0000, Anurag Mandal wrote:
> This patch series addresses two memory handling issues in the ice PMD.
>
> - The first one makes memory allocation and release symmetric.
> Several buffers obtained through ice_malloc(), ice_calloc()
> or ice_memdup() were released with rte_free() instead of ice_free().
> Both APIs currently map to the same underlying allocator.
> However, mixing them is inconsistent and would break if the OS
> abstraction layer ever changes.
>
> - The second one fixes an unchecked allocation in ice_tx_queue_start()
> which dereferences the Tx time queue context buffer returned by
> ice_malloc() without NULL check.
> On allocation failure, the E830 send-on-timestamp path therefore crashes
> instead of reporting "No Memory" error, and also the already allocated
> txq_elem buffer gets leaked.
>
> Anurag Mandal (2):
> net/ice: free memory with matching allocator
> net/ice: fix unchecked Tx time context allocation
>
> drivers/net/intel/ice/ice_acl_filter.c | 10 +++++-----
> drivers/net/intel/ice/ice_dcf.c | 2 +-
> drivers/net/intel/ice/ice_dcf_parent.c | 2 +-
> drivers/net/intel/ice/ice_ethdev.c | 14 +++++++-------
> drivers/net/intel/ice/ice_fdir_filter.c | 12 ++++++------
> drivers/net/intel/ice/ice_rxtx.c | 22 +++++++++++++---------
> 6 files changed, 33 insertions(+), 29 deletions(-)
>
Patches applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2026-10-07 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 7:58 [PATCH 0/2] net/ice: fix memory handling issues Anurag Mandal
2026-10-07 7:58 ` [PATCH 1/2] net/ice: free memory with matching allocator Anurag Mandal
2026-10-07 8:04 ` Bruce Richardson
2026-10-07 7:58 ` [PATCH 2/2] net/ice: fix unchecked Tx time context allocation Anurag Mandal
2026-10-07 9:31 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asYRf0mgWZu8sUmi@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=anurag.mandal@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox