DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	"Ciara Loftus" <ciara.loftus@intel.com>
Subject: Re: [PATCH v2 2/3] net/iavf: do not include private headers in testpmd
Date: Thu, 15 Oct 2026 15:33:33 +0100	[thread overview]
Message-ID: <atDkPRQ8fZ1FhhXe@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <1e05a203951906eb042fcf1010d2b120c85bb4d2.1792074055.git.anatoly.burakov@intel.com>

On Thu, Oct 15, 2026 at 03:21:03PM +0100, Anatoly Burakov wrote:
> Currently, the `iavf_testpmd.c` file includes headers that are only
> available to driver itself, but should not be available to applications,
> including testpmd.
> 
> Fix the testpmd file to not include private headers (they are unused).
> 
> Fixes: c702044ed909 ("net/iavf: remove Tx LLDP dynfield method")
> Cc: ciara.loftus@intel.com
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>  drivers/net/intel/iavf/iavf_testpmd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/intel/iavf/iavf_testpmd.c b/drivers/net/intel/iavf/iavf_testpmd.c
> index f3b932da04..1146f534e3 100644
> --- a/drivers/net/intel/iavf/iavf_testpmd.c
> +++ b/drivers/net/intel/iavf/iavf_testpmd.c
> @@ -9,9 +9,7 @@
>  #include <cmdline_parse_num.h>
>  #include <cmdline_parse_string.h>
>  
> -#include "iavf.h"
>  #include "testpmd.h"
> -#include "iavf_rxtx.h"
>  
>  struct cmd_reinit_result {
>  	cmdline_fixed_string_t port;
> -- 
> 2.52.0
> 

  reply	other threads:[~2026-10-15 14:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 20:34 [PATCH] net/ixgbe: avoid private driver include in testpmd Thomas Monjalon
2026-10-15  8:53 ` Burakov, Anatoly
2026-10-15  9:13   ` Thomas Monjalon
2026-10-15 10:41     ` Burakov, Anatoly
2026-10-15 11:18       ` David Marchand
2026-10-15 11:21         ` Burakov, Anatoly
2026-10-15 11:50           ` Thomas Monjalon
2026-10-15 14:01             ` Burakov, Anatoly
2026-10-15 14:21 ` [PATCH v2 1/3] " Anatoly Burakov
2026-10-15 14:21   ` [PATCH v2 2/3] net/iavf: do not include private headers " Anatoly Burakov
2026-10-15 14:33     ` Bruce Richardson [this message]
2026-10-15 14:45     ` Medvedkin, Vladimir
2026-10-15 14:21   ` [PATCH v2 3/3] net/ice: " Anatoly Burakov
2026-10-15 14:36     ` Bruce Richardson
2026-10-15 14:39       ` Bruce Richardson
2026-10-15 14:52     ` Medvedkin, Vladimir
2026-10-15 15:00       ` Burakov, Anatoly
2026-10-15 15:21         ` Bruce Richardson
2026-10-15 15:29           ` Burakov, Anatoly
2026-10-15 14:44   ` [PATCH v2 1/3] net/ixgbe: avoid private driver include " Medvedkin, Vladimir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atDkPRQ8fZ1FhhXe@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox