From: Bruce Richardson <bruce.richardson@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: Re: [PATCH v3 1/3] app/crypto-perf: fix asymmetric op pool name size
Date: Mon, 19 Oct 2026 08:47:57 +0100 [thread overview]
Message-ID: <atXLLZ90G06UWwx2@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35F65AB9@smartserver.smartshare.dk>
On Fri, Oct 16, 2026 at 10:13:53PM +0200, Morten Brørup wrote:
> > @@ -154,7 +154,7 @@ cperf_alloc_common_memory(const struct
> > cperf_options *options,
> >
> > if (cperf_is_asym_test(options)) {
> > crypto_op_size += sizeof(struct rte_crypto_asym_op);
> > - snprintf(pool_name, RTE_MEMPOOL_NAMESIZE,
> > "perf_asym_op_pool%u",
> > + snprintf(pool_name, sizeof(pool_name),
> > "perf_asym_op_pool%u",
> > rte_socket_id());
> > *pool = rte_crypto_op_pool_create(
> > pool_name, RTE_CRYPTO_OP_TYPE_ASYMMETRIC,
>
> snprintf() doesn't ensure zero-terminated string.
Actually it does. If return value is size of more, then truncation has
occurred, and only size-1 bytes plus null have been written.
> Not new, and don't know if it matters; just mentioning it.
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
next prev parent reply other threads:[~2026-10-19 7:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 21:57 [PATCH] eal: increase memzone name size to 64 Stephen Hemminger
2026-09-22 10:42 ` Morten Brørup
2026-10-13 9:01 ` Thomas Monjalon
2026-09-22 15:52 ` [PATCH v2 0/3] increase memzone name size and fix rib/fib prefixes Stephen Hemminger
2026-09-22 15:52 ` [PATCH v2 1/3] app/crypto-perf: fix asymmetric op pool name size Stephen Hemminger
2026-09-22 18:25 ` [EXTERNAL] " Akhil Goyal
2026-09-22 15:52 ` [PATCH v2 2/3] eal: increase memzone name size to 64 Stephen Hemminger
2026-10-13 9:02 ` Thomas Monjalon
2026-09-22 15:52 ` [PATCH v2 3/3] fib, rib: fix name prefixes Stephen Hemminger
2026-09-22 19:46 ` Medvedkin, Vladimir
2026-10-16 15:38 ` [PATCH v3 0/3] increase memzone name size and fix rib/fib prefix Stephen Hemminger
2026-10-16 15:38 ` [PATCH v3 1/3] app/crypto-perf: fix asymmetric op pool name size Stephen Hemminger
2026-10-16 20:13 ` Morten Brørup
2026-10-19 7:47 ` Bruce Richardson [this message]
2026-10-19 7:51 ` Morten Brørup
2026-10-16 15:38 ` [PATCH v3 2/3] eal: increase memzone name size to 64 Stephen Hemminger
2026-10-16 20:11 ` Morten Brørup
2026-10-16 15:38 ` [PATCH v3 3/3] fib, rib: fix name prefixes Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atXLLZ90G06UWwx2@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox