From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
"Qiming Yang" <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [PATCH v4 03/10] net/iavf: fix false success on flow validation
Date: Thu, 22 Oct 2026 13:57:58 +0100 [thread overview]
Message-ID: <atoIVtc14Y8dCl4D@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <d541e9890b27dfc0b2d524d46133ddbfe3523cdb.1792592724.git.anatoly.burakov@intel.com>
On Wed, Oct 21, 2026 at 03:25:43PM +0100, Anatoly Burakov wrote:
> `iavf_parse_engine_validate()` sets an error when validation fails, but
> then returns the engine pointer. `iavf_flow_process_filter()` treats a
> non-NULL engine as success, so `rte_flow_validate()` can accept an
> invalid flow.
>
> Return `NULL` on validation failure and return the engine only after
> validation succeeds.
>
> Fixes: ff2d0c345c3b ("net/iavf: support generic flow API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> drivers/net/intel/iavf/iavf_generic_flow.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-10-22 12:58 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 15:18 [PATCH v1 0/7] IAVF Fixes Anatoly Burakov
2026-10-14 15:18 ` [PATCH v1 1/7] net/iavf: fix memory leak in flow teardown Anatoly Burakov
2026-10-14 15:18 ` [PATCH v1 2/7] net/iavf: fix null engine for egress security flows Anatoly Burakov
2026-10-14 15:18 ` [PATCH v1 3/7] net/iavf: fix generic flow error-path leaks Anatoly Burakov
2026-10-14 15:18 ` [PATCH v1 4/7] net/iavf: fix flow subscription metadata leaks Anatoly Burakov
2026-10-14 15:18 ` [PATCH v1 5/7] net/iavf: fix hash flow " Anatoly Burakov
2026-10-16 3:12 ` Mandal, Anurag
2026-10-16 11:00 ` Burakov, Anatoly
2026-10-14 15:18 ` [PATCH v1 6/7] net/iavf: fix IPsec " Anatoly Burakov
2026-10-14 15:18 ` [PATCH v1 7/7] net/iavf: do not store ethdev pointer Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 0/9] IAVF Fixes Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 1/9] net/iavf: keep device stopped if start fails Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 2/9] net/iavf: do not store ethdev pointer Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 3/9] net/iavf: fix false success on flow validation Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 4/9] net/iavf: fix memory leak in raw pattern parsing Anatoly Burakov
2026-10-19 15:13 ` Burakov, Anatoly
2026-10-19 15:06 ` [PATCH v2 5/9] net/iavf: fix memory leaks around IRQ resources Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 6/9] net/iavf: fix generic flow error-path leaks Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 7/9] net/iavf: centralize memory management for flows Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 8/9] net/iavf: fix null engine for egress security flows Anatoly Burakov
2026-10-19 15:06 ` [PATCH v2 9/9] net/iavf: fix IPsec flow metadata leaks Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 00/10] IAVF Fixes Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 01/10] net/iavf: keep device stopped if start fails Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 02/10] net/iavf: do not store ethdev pointer Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 03/10] net/iavf: fix false success on flow validation Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 04/10] net/iavf: fix memory leaks around IRQ resources Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 05/10] net/iavf: fix generic flow error-path leaks Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 06/10] net/iavf: centralize memory management for flows Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 07/10] net/iavf: skip RSS teardown during PF-initiated reset Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 08/10] net/iavf: remove redundant reset checks from RSS engine Anatoly Burakov
2026-10-20 9:11 ` [PATCH v3 09/10] net/iavf: fix null engine for egress security flows Anatoly Burakov
2026-10-20 9:35 ` Radu Nicolau
2026-10-20 9:11 ` [PATCH v3 10/10] net/iavf: fix IPsec flow metadata leaks Anatoly Burakov
2026-10-20 9:36 ` Radu Nicolau
2026-10-21 14:25 ` [PATCH v4 00/10] IAVF Fixes Anatoly Burakov
2026-10-21 14:25 ` [PATCH v4 01/10] net/iavf: keep device stopped if start fails Anatoly Burakov
2026-10-22 12:57 ` Bruce Richardson
2026-10-21 14:25 ` [PATCH v4 02/10] net/iavf: do not store ethdev pointer Anatoly Burakov
2026-10-22 12:57 ` Bruce Richardson
2026-10-21 14:25 ` [PATCH v4 03/10] net/iavf: fix false success on flow validation Anatoly Burakov
2026-10-22 12:57 ` Bruce Richardson [this message]
2026-10-21 14:25 ` [PATCH v4 04/10] net/iavf: fix memory leaks around IRQ resources Anatoly Burakov
2026-10-22 13:08 ` Bruce Richardson
2026-10-21 14:25 ` [PATCH v4 05/10] net/iavf: fix generic flow error-path leaks Anatoly Burakov
2026-10-22 13:15 ` Bruce Richardson
2026-10-21 14:25 ` [PATCH v4 06/10] net/iavf: centralize memory management for flows Anatoly Burakov
2026-10-22 14:18 ` Bruce Richardson
2026-10-21 14:25 ` [PATCH v4 07/10] net/iavf: skip RSS teardown during PF-initiated reset Anatoly Burakov
2026-10-22 14:31 ` Bruce Richardson
2026-10-21 14:25 ` [PATCH v4 08/10] net/iavf: remove redundant reset checks from RSS engine Anatoly Burakov
2026-10-22 14:41 ` Bruce Richardson
2026-10-21 14:25 ` [PATCH v4 09/10] net/iavf: fix null engine for egress security flows Anatoly Burakov
2026-10-21 14:25 ` [PATCH v4 10/10] net/iavf: fix IPsec flow metadata leaks Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 00/10] IAVF Fixes Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 01/10] net/iavf: keep device stopped if start fails Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 02/10] net/iavf: do not store ethdev pointer Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 03/10] net/iavf: fix false success on flow validation Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 04/10] net/iavf: fix memory leaks around IRQ resources Anatoly Burakov
2026-10-23 9:37 ` Bruce Richardson
2026-10-23 9:32 ` [PATCH v5 05/10] net/iavf: fix generic flow error-path leaks Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 06/10] net/iavf: centralize memory management for flows Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 07/10] net/iavf: skip RSS teardown during PF-initiated reset Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 08/10] net/iavf: remove redundant reset checks from RSS engine Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 09/10] net/iavf: fix null engine for egress security flows Anatoly Burakov
2026-10-23 9:32 ` [PATCH v5 10/10] net/iavf: fix IPsec flow metadata leaks Anatoly Burakov
2026-10-23 10:26 ` [PATCH v5 00/10] IAVF Fixes Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atoIVtc14Y8dCl4D@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox