DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anurag Mandal <anurag.mandal@intel.com>
Cc: <dev@dpdk.org>, <vladimir.medvedkin@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH] net/iavf: fix RSS rule overwriting an existing one
Date: Tue, 27 Oct 2026 12:01:12 +0000	[thread overview]
Message-ID: <auCSiDjFkBOkglWU@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20261026104711.175208-1-anurag.mandal@intel.com>

On Mon, Oct 26, 2026 at 10:47:11AM +0000, Anurag Mandal wrote:
> An RSS flow rule only selects the hash input set of a packet type, and
> the PF keeps a single configuration per packet type for the VF VSI.
> When a second rule is created for a packet type already used by another
> rule, the PF silently replaces the first configuration, while both flow
> handles remain valid.
> For example,:
> 
>   flow create 0 ingress pattern eth / vlan vid is 1500 / ipv6 / end
>     actions rss types ipv6 l3-dst-only end queues end / end
>   flow create 0 ingress pattern eth / vlan vid is 2640 / ipv6 / end
>     actions rss types ipv6 l3-src-only end queues end / end
> 
> Only the second rule is applied, whatever the VLAN ID of the packet, and
> destroying it leaves the first rule without any hardware configuration.
> 
> Reject the creation of an RSS rule when another RSS rule of the port
> already uses the same protocol header stack. The existing rule has to
> be destroyed first to change the hash input set of that packet type.
> Raw pattern rules are not checked, as their packet type is only known
> by the PF parser.
> 
> Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
> ---
>  drivers/net/intel/iavf/iavf_hash.c | 47 ++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Patch applied to dpdk-next-net-intel.

/Bruce

      reply	other threads:[~2026-10-27 12:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 10:47 [PATCH] net/iavf: fix RSS rule overwriting an existing one Anurag Mandal
2026-10-27 12:01 ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auCSiDjFkBOkglWU@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anurag.mandal@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox